feat: Benchmark suite update (AztecProtocol/barretenberg#508)

feat: Benchmark suite update

barretenberg/.github/workflows/benchmarks.yml

@@ -0,0 +1,69 @@
+name: Barretenberg Benchmarks
+
+# Only run on push to master
+on:
+  push:
+    branches:
+      - master
+
+# This will cancel previous runs when a branch or PR is updated
+concurrency:
+  group: ${{ github.workflow }}-${{ github.head_ref || github.ref || github.run_id }}
+  cancel-in-progress: true
+
+jobs:
+  bberg-bench:
+    name: Barretenberg Benchmarks
+    runs-on: ubuntu-latest # run in linux environment
+
+    steps:
+
+      - name: Checkout barretenberg
+        uses: actions/checkout@v3
+        with:
+          ref: ${{ github.head_ref }} # checkout HEAD of triggering branch
+          token: ${{ secrets.GITHUB_TOKEN }}
+
+     # Only run in Linux environment for now
+      - name: Setup Linux environment
+        run: |
+          sudo apt update
+          sudo apt install libomp-dev cmake ninja-build
+
+      - name: Download SRS elements
+        working-directory: cpp/srs_db
+        run: ./download_ignition.sh 3 # only download first 4 transcript files
+
+      - name: Build Honk benchmarks
+        working-directory: cpp
+        run: |
+          cmake --preset bench
+          cmake --build --preset bench --target ultra_honk_bench
+      
+      - name: Run Honk benchmarks
+        working-directory: cpp/build-bench
+        run: |
+          bin/ultra_honk_bench --benchmark_format=json > ../src/barretenberg/benchmark/honk_bench/bench_results.json
+      
+      # Utilize github-action-benchmark to automatically update the plots at 
+      # https://aztecprotocol.github.io/barretenberg/dev/bench/ with new benchmark data.
+      # This also creates an alert if benchmarks exceed the threshold specified below.
+      - name: Store benchmark result
+        uses: benchmark-action/github-action-benchmark@v1
+        with:
+          name: C++ Benchmark
+          tool: 'googlecpp'
+          output-file-path: cpp/src/barretenberg/benchmark/honk_bench/bench_results.json
+          # Access token to deploy GitHub Pages branch
+          github-token: ${{ secrets.GITHUB_TOKEN }}
+          # Push and deploy GitHub pages branch automatically
+          auto-push: true
+          # Enable Job Summary for PRs
+          summary-always: true
+          # Show alert with commit comment on detecting possible performance regression
+          alert-threshold: '120%' # alert if bench result is 1.2x worse
+          comment-on-alert: true
+          fail-on-alert: false
+          alert-comment-cc-users: '@ledwards2225'
+
+

barretenberg/cpp/src/barretenberg/benchmark/honk_bench/CMakeLists.txt

@@ -1,18 +1,23 @@
-add_executable(honk_bench main.bench.cpp honk.bench.cpp ultra_honk.bench.cpp)
+# Each source represents a separate benchmark suite 
+set(BENCHMARK_SOURCES
+standard_honk.bench.cpp
+standard_plonk.bench.cpp
+ultra_honk.bench.cpp
+ultra_plonk.bench.cpp
+)
 
-target_link_libraries(
-  honk_bench
-  stdlib_primitives
-  common
+# Required libraries for benchmark suites
+set(LINKED_LIBRARIES
   stdlib_sha256
   stdlib_keccak
   stdlib_merkle_tree
-  env
   benchmark::benchmark
 )
 
-add_custom_target(
-    run_honk_bench
-    COMMAND honk_bench
-    WORKING_DIRECTORY ${CMAKE_BINARY_DIR}
-)
+# Add executable and custom target for each suite, e.g. standard_honk_bench
+foreach(BENCHMARK_SOURCE ${BENCHMARK_SOURCES})
+  get_filename_component(BENCHMARK_NAME ${BENCHMARK_SOURCE} NAME_WE) # extract name without extension
+  add_executable(${BENCHMARK_NAME}_bench main.bench.cpp ${BENCHMARK_SOURCE} benchmark_utilities.hpp)
+  target_link_libraries(${BENCHMARK_NAME}_bench ${LINKED_LIBRARIES})
+  add_custom_target(run_${BENCHMARK_NAME} COMMAND ${BENCHMARK_NAME} WORKING_DIRECTORY ${CMAKE_BINARY_DIR})
+endforeach()

barretenberg/cpp/src/barretenberg/benchmark/honk_bench/benchmark_utilities.hpp

@@ -0,0 +1,231 @@
+#include "barretenberg/crypto/ecdsa/ecdsa.hpp"
+#include "barretenberg/ecc/curves/bn254/fr.hpp"
+#include "barretenberg/honk/proof_system/ultra_prover.hpp"
+#include "barretenberg/honk/proof_system/ultra_verifier.hpp"
+#include <benchmark/benchmark.h>
+#include <cstddef>
+#include "barretenberg/honk/composer/standard_honk_composer.hpp"
+#include "barretenberg/plonk/composer/standard_plonk_composer.hpp"
+#include "barretenberg/stdlib/encryption/ecdsa/ecdsa.hpp"
+#include "barretenberg/stdlib/hash/keccak/keccak.hpp"
+#include "barretenberg/stdlib/primitives/curves/secp256k1.hpp"
+#include "barretenberg/stdlib/primitives/packed_byte_array/packed_byte_array.hpp"
+#include "barretenberg/stdlib/hash/sha256/sha256.hpp"
+#include "barretenberg/stdlib/primitives/bool/bool.hpp"
+#include "barretenberg/stdlib/primitives/field/field.hpp"
+#include "barretenberg/stdlib/primitives/witness/witness.hpp"
+#include "barretenberg/stdlib/merkle_tree/merkle_tree.hpp"
+#include "barretenberg/stdlib/merkle_tree/membership.hpp"
+#include "barretenberg/stdlib/merkle_tree/memory_store.hpp"
+#include "barretenberg/stdlib/merkle_tree/memory_tree.hpp"
+
+using namespace benchmark;
+
+namespace bench_utils {
+
+struct BenchParams {
+    // Num iterations of the operation of interest in a test circuit, e.g. num sha256 hashes
+    static constexpr size_t MIN_NUM_ITERATIONS = 10;
+    static constexpr size_t MAX_NUM_ITERATIONS = 10;
+
+    // Log num gates; for simple circuits only, e.g. standard arithmetic circuit
+    static constexpr size_t MIN_LOG_NUM_GATES = 16;
+    static constexpr size_t MAX_LOG_NUM_GATES = 16;
+
+    static constexpr size_t NUM_REPETITIONS = 1;
+};
+
+/**
+ * @brief Generate test circuit with basic arithmetic operations
+ *
+ * @param composer
+ * @param num_iterations
+ */
+template <typename Composer> void generate_basic_arithmetic_circuit(Composer& composer, size_t num_gates)
+{
+    plonk::stdlib::field_t a(plonk::stdlib::witness_t(&composer, barretenberg::fr::random_element()));
+    plonk::stdlib::field_t b(plonk::stdlib::witness_t(&composer, barretenberg::fr::random_element()));
+    plonk::stdlib::field_t c(&composer);
+    for (size_t i = 0; i < (num_gates / 4) - 4; ++i) {
+        c = a + b;
+        c = a * c;
+        a = b * b;
+        b = c * c;
+    }
+}
+
+/**
+ * @brief Generate test circuit with specified number of sha256 hashes
+ *
+ * @param composer
+ * @param num_iterations
+ */
+template <typename Composer> void generate_sha256_test_circuit(Composer& composer, size_t num_iterations)
+{
+    std::string in;
+    in.resize(32);
+    for (size_t i = 0; i < 32; ++i) {
+        in[i] = 0;
+    }
+    proof_system::plonk::stdlib::packed_byte_array<Composer> input(&composer, in);
+    for (size_t i = 0; i < num_iterations; i++) {
+        input = proof_system::plonk::stdlib::sha256<Composer>(input);
+    }
+}
+
+/**
+ * @brief Generate test circuit with specified number of keccak hashes
+ *
+ * @param composer
+ * @param num_iterations
+ */
+template <typename Composer> void generate_keccak_test_circuit(Composer& composer, size_t num_iterations)
+{
+    std::string in = "abcdefghijklmnopqrstuvwxyz0123456789abcdefghijklmnopqrstuvwxyz01";
+
+    proof_system::plonk::stdlib::byte_array<Composer> input(&composer, in);
+    for (size_t i = 0; i < num_iterations; i++) {
+        input = proof_system::plonk::stdlib::keccak<Composer>::hash(input);
+    }
+}
+
+/**
+ * @brief Generate test circuit with specified number of ecdsa verifications
+ *
+ * @param composer
+ * @param num_iterations
+ */
+template <typename Composer> void generate_ecdsa_verification_test_circuit(Composer& composer, size_t num_iterations)
+{
+    using curve = proof_system::plonk::stdlib::secp256k1<Composer>;
+    using fr = typename curve::fr;
+    using fq = typename curve::fq;
+    using g1 = typename curve::g1;
+
+    std::string message_string = "Instructions unclear, ask again later.";
+
+    crypto::ecdsa::key_pair<fr, g1> account;
+    for (size_t i = 0; i < num_iterations; i++) {
+        // Generate unique signature for each iteration
+        account.private_key = curve::fr::random_element();
+        account.public_key = curve::g1::one * account.private_key;
+
+        crypto::ecdsa::signature signature =
+            crypto::ecdsa::construct_signature<Sha256Hasher, fq, fr, g1>(message_string, account);
+
+        bool first_result =
+            crypto::ecdsa::verify_signature<Sha256Hasher, fq, fr, g1>(message_string, account.public_key, signature);
+
+        std::vector<uint8_t> rr(signature.r.begin(), signature.r.end());
+        std::vector<uint8_t> ss(signature.s.begin(), signature.s.end());
+        uint8_t vv = signature.v;
+
+        typename curve::g1_bigfr_ct public_key = curve::g1_bigfr_ct::from_witness(&composer, account.public_key);
+
+        proof_system::plonk::stdlib::ecdsa::signature<Composer> sig{ typename curve::byte_array_ct(&composer, rr),
+                                                                     typename curve::byte_array_ct(&composer, ss),
+                                                                     proof_system::plonk::stdlib::uint8<Composer>(
+                                                                         &composer, vv) };
+
+        typename curve::byte_array_ct message(&composer, message_string);
+
+        // Verify ecdsa signature
+        proof_system::plonk::stdlib::ecdsa::verify_signature<Composer,
+                                                             curve,
+                                                             typename curve::fq_ct,
+                                                             typename curve::bigfr_ct,
+                                                             typename curve::g1_bigfr_ct>(message, public_key, sig);
+    }
+}
+
+/**
+ * @brief Generate test circuit with specified number of merkle membership checks
+ *
+ * @param composer
+ * @param num_iterations
+ */
+template <typename Composer> void generate_merkle_membership_test_circuit(Composer& composer, size_t num_iterations)
+{
+    using namespace proof_system::plonk::stdlib;
+    using field_ct = field_t<Composer>;
+    using witness_ct = witness_t<Composer>;
+    using witness_ct = witness_t<Composer>;
+    using MemStore = merkle_tree::MemoryStore;
+    using MerkleTree_ct = merkle_tree::MerkleTree<MemStore>;
+
+    MemStore store;
+    const size_t tree_depth = 7;
+    auto merkle_tree = MerkleTree_ct(store, tree_depth);
+
+    for (size_t i = 0; i < num_iterations; i++) {
+        // For each iteration update and check the membership of a different value
+        size_t idx = i;
+        size_t value = i * 2;
+        merkle_tree.update_element(idx, value);
+
+        field_ct root_ct = witness_ct(&composer, merkle_tree.root());
+        auto idx_ct = field_ct(witness_ct(&composer, fr(idx))).decompose_into_bits();
+        auto value_ct = field_ct(value);
+
+        merkle_tree::check_membership(
+            root_ct, merkle_tree::create_witness_hash_path(composer, merkle_tree.get_hash_path(idx)), value_ct, idx_ct);
+    }
+}
+
+/**
+ * @brief Performs proof constuction for benchmarks based on a provided circuit function
+ *
+ * @details This function assumes state.range refers to num_gates which is the size of the underlying circuit
+ *
+ * @tparam Composer
+ * @param state
+ * @param test_circuit_function
+ */
+template <typename Composer>
+void construct_proof_with_specified_num_gates(State& state, void (*test_circuit_function)(Composer&, size_t)) noexcept
+{
+    barretenberg::srs::init_crs_factory("../srs_db/ignition");
+    auto num_gates = static_cast<size_t>(1 << (size_t)state.range(0));
+    for (auto _ : state) {
+        // Constuct circuit and prover; don't include this part in measurement
+        state.PauseTiming();
+        auto composer = Composer();
+        test_circuit_function(composer, num_gates);
+        auto ext_prover = composer.create_prover();
+        state.ResumeTiming();
+
+        // Construct proof
+        auto proof = ext_prover.construct_proof();
+    }
+}
+
+/**
+ * @brief Performs proof constuction for benchmarks based on a provided circuit function
+ *
+ * @details This function assumes state.range refers to num_iterations which is the number of times to perform a given
+ * basic operation in the circuit, e.g. number of hashes
+ *
+ * @tparam Composer
+ * @param state
+ * @param test_circuit_function
+ */
+template <typename Composer>
+void construct_proof_with_specified_num_iterations(State& state,
+                                                   void (*test_circuit_function)(Composer&, size_t)) noexcept
+{
+    barretenberg::srs::init_crs_factory("../srs_db/ignition");
+    auto num_iterations = static_cast<size_t>(state.range(0));
+    for (auto _ : state) {
+        // Constuct circuit and prover; don't include this part in measurement
+        state.PauseTiming();
+        auto composer = Composer();
+        test_circuit_function(composer, num_iterations);
+        auto ext_prover = composer.create_prover();
+        state.ResumeTiming();
+
+        // Construct proof
+        auto proof = ext_prover.construct_proof();
+    }
+}
+
+} // namespace bench_utils