Apply suggestions from code review

Co-authored-by: esau <[email protected]>
AztecProtocol · Feb 22, 2024 · 5763d55 · 5763d55
1 parent 569e9c4
commit 5763d55
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 5 deletions.
diff --git a/docs/docs/learn/concepts/communication/public_private_calls/slow_updates_tree.md b/docs/docs/learn/concepts/communication/public_private_calls/slow_updates_tree.md
@@ -41,7 +41,7 @@ graph TD;
     CurrentM --> Value1[Current Value 1]
     CurrentM --> Value2[Current Value 2]
     CurrentM --> ValueN[Current Value n]
-    Pending --> PendingM[pending note hash 1]
+    Pending --> PendingM[Pending Note Hash 1]
     PendingM --> PValue1[Pending Value 1]
     PendingM --> PValue2[Pending Value 2]
     PendingM --> PValueN[Pending Value n]

diff --git a/noir-projects/noir-protocol-circuits/src/crates/types/src/hash.nr b/noir-projects/noir-protocol-circuits/src/crates/types/src/hash.nr
@@ -302,7 +302,7 @@ pub fn compute_unique_siloed_note_hash(nonce: Field, siloed_note_hash: Field) ->
     )
 }
 
-pub fn compute_unique_siloed_note_hashs<N>(
+pub fn compute_unique_siloed_note_hashes<N>(
     first_nullifier: Field,
     siloed_note_hashs: [SideEffect; N]
 ) -> [SideEffect; N] {

diff --git a/yarn-project/end-to-end/src/shared/cross_chain_test_harness.ts b/yarn-project/end-to-end/src/shared/cross_chain_test_harness.ts
@@ -440,7 +440,7 @@ export class CrossChainTestHarness {
   }
 
   async redeemShieldPrivatelyOnL2(shieldAmount: bigint, secret: Fr) {
-    this.logger('Spending note hash in private call');
+    this.logger('Spending note in private call');
     const privateTx = this.l2Token.methods.redeem_shield(this.ownerAddress, shieldAmount, secret).send();
     const privateReceipt = await privateTx.wait();
     expect(privateReceipt.status).toBe(TxStatus.MINED);

diff --git a/yarn-project/pxe/src/kernel_prover/proof_creator.ts b/yarn-project/pxe/src/kernel_prover/proof_creator.ts
@@ -53,7 +53,7 @@ export interface ProofCreator {
   /**
    * Computes the siloed commitments for a given set of public inputs.
    *
-   * @param publicInputs - The public inputs containing the contract address and new note hashes to be used in generating siloed commitments.
+   * @param publicInputs - The public inputs containing the contract address and new note hashes to be used in generating siloed note hashes.
    * @returns An array of Fr (finite field) elements representing the siloed commitments.
    */
   getSiloedCommitments(publicInputs: PrivateCircuitPublicInputs): Promise<Fr[]>;

diff --git a/yarn-project/simulator/src/public/execution.ts b/yarn-project/simulator/src/public/execution.ts
@@ -22,7 +22,7 @@ export interface PublicExecutionResult {
   execution: PublicExecution;
   /** The return values of the function. */
   returnValues: Fr[];
-  /** The new note hashes to be inserted into the commitments tree. */
+  /** The new note hashes to be inserted into the note hashes tree. */
   newNoteHashes: SideEffect[];
   /** The new l2 to l1 messages generated in this call. */
   newL2ToL1Messages: L2ToL1Message[];