-
Notifications
You must be signed in to change notification settings - Fork 298
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: Make Brillig do integer arithmetic operations using u128 instea…
…d of Bigint (#7518) This PR: - Restricts Brillig bit sizes to the ones supported by noir and the AVM - Avoids using BigInteger, using u128 to represent integers in brillig instead - Fixes a bug in truncate discovered by making bit size an enum - Removes truncation in brillig_directive_quotient that wasn't needed anymore This generates a big performance boost, where [this test](https://github.com/zac-williamson/noir_bigcurve/blob/main/src/bigcurve_test.nr#L129) spent 110 seconds running the ACVM before, and 34 seconds after this change. Before: ![image](https://github.com/user-attachments/assets/18ba8cfa-867d-4a68-8d80-fdbda7018bd8) After: ![image](https://github.com/user-attachments/assets/06b9eb08-5dbc-4be7-9f88-f32065839038)
- Loading branch information
1 parent
086522d
commit 4a2011e
Showing
25 changed files
with
5,220 additions
and
4,055 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.