Skip to content

Commit

Permalink
chore: nuking ancient redundant test (#9941)
Browse files Browse the repository at this point in the history
  • Loading branch information
benesjan authored and stevenplatt committed Nov 13, 2024
1 parent 6bc4c2c commit 31f81d1
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 61 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,6 @@ Let’s do the similar for the private flow:
Here we want to send a message to mint tokens privately on Aztec! Some key differences from the previous method are:

- The content hash uses a different function name - `mint_to_private`. This is done to make it easy to separate concerns. If the contentHash between the public and private message was the same, then an attacker could consume a private message publicly!
- Since we want to mint tokens privately, we shouldn’t specify a `to` Aztec address (remember that Ethereum is completely public). Instead, we will use a secret hash - `secretHashForRedeemingMintedNotes`. Only he who knows the preimage to the secret hash can actually mint the notes. This is similar to the mechanism we use for message consumption on L2
- Like with the public flow, we move the user’s funds to the portal
- We now send the message to the inbox with the `recipient` (the sister contract on L2 along with the version of aztec the message is intended for) and the `secretHashForL2MessageConsumption` (such that on L2, the consumption of the message can be private).

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -556,7 +556,7 @@ contract Token {
) {
let token = Token::at(context.this_address());

// We prepare the transfer.
// We prepare the partial note to which we'll "send" the minted amount.
let hiding_point_slot = _prepare_transfer_to_private(from, to, &mut context, storage);

// At last we finalize the mint. Usage of the `unsafe` method here is safe because we set the `from`
Expand Down

This file was deleted.

1 change: 1 addition & 0 deletions yarn-project/yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -3512,6 +3512,7 @@ __metadata:
"@noir-lang/acvm_js": 0.54.0
"@noir-lang/noirc_abi": 0.38.0
"@noir-lang/types": 0.38.0
checksum: 99cdc1f1e352d45a8968261dc7f1d68d58b5bca8177e25c610667eb60954436356c56852e6a23fbf69ddb8db9b92494736438c0852f4702d33e8d0e981e60552
languageName: node
linkType: hard

Expand Down

0 comments on commit 31f81d1

Please sign in to comment.