Skip to content

Commit

Permalink
chore: build acir test programs in parallel to e2e build step (#9988)
Browse files Browse the repository at this point in the history
This PR shaves about a minute off of the `acir-test`s jobs as we can
build all of the ACIR programs in parallel with the main `build` step.
I've decided to add an extra dependency on `build` so that we're only
changing when the ACIR is generated but still running the tests at the
same time.

The `noir+build-acir-tests` target only depends on the `+nargo` target
and nothing outside.
  • Loading branch information
TomAFrench authored Nov 18, 2024
1 parent db6fdc2 commit 1aaee26
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -385,7 +385,7 @@ jobs:
run: earthly-ci --no-output ./+test

noir-build-acir-tests:
needs: [build, configure]
needs: [build-images, configure]
runs-on: ${{ needs.configure.outputs.username }}-x86
if: needs.configure.outputs.barretenberg == 'true' || needs.configure.outputs.noir == 'true'
steps:
Expand All @@ -399,7 +399,7 @@ jobs:
run: earthly-ci --no-output ./noir/+build-acir-tests

bb-acir-tests-bb:
needs: [noir-build-acir-tests, configure]
needs: [noir-build-acir-tests, build, configure]
runs-on: ${{ needs.configure.outputs.username }}-x86
if: needs.configure.outputs.barretenberg == 'true' || needs.configure.outputs.noir == 'true'
steps:
Expand All @@ -414,7 +414,7 @@ jobs:
run: earthly-ci --no-output ./+barretenberg-acir-tests-bb

bb-acir-tests-bb-ultra-plonk:
needs: [noir-build-acir-tests, configure]
needs: [noir-build-acir-tests, build, configure]
runs-on: ${{ needs.configure.outputs.username }}-x86
if: needs.configure.outputs.barretenberg == 'true' || needs.configure.outputs.noir == 'true'
steps:
Expand All @@ -429,7 +429,7 @@ jobs:
run: earthly-ci --no-output ./+barretenberg-acir-tests-bb-ultra-plonk

bb-acir-tests-bb-ultra-honk:
needs: [noir-build-acir-tests, configure]
needs: [noir-build-acir-tests, build, configure]
runs-on: ${{ needs.configure.outputs.username }}-x86
if: needs.configure.outputs.barretenberg == 'true' || needs.configure.outputs.noir == 'true'
steps:
Expand All @@ -444,7 +444,7 @@ jobs:
run: earthly-ci --no-output ./+barretenberg-acir-tests-bb-ultra-honk

bb-acir-tests-bb-mega-honk:
needs: [noir-build-acir-tests, configure]
needs: [noir-build-acir-tests, build, configure]
runs-on: ${{ needs.configure.outputs.username }}-x86
if: needs.configure.outputs.barretenberg == 'true' || needs.configure.outputs.noir == 'true'
steps:
Expand All @@ -459,7 +459,7 @@ jobs:
run: earthly-ci --no-output ./+barretenberg-acir-tests-bb-mega-honk

bb-acir-tests-sol:
needs: [noir-build-acir-tests, configure]
needs: [noir-build-acir-tests, build, configure]
runs-on: ${{ needs.configure.outputs.username }}-x86
if: needs.configure.outputs.barretenberg == 'true' || needs.configure.outputs.noir == 'true'
steps:
Expand All @@ -474,7 +474,7 @@ jobs:
run: earthly-ci --no-output ./+barretenberg-acir-tests-sol

bb-acir-tests-sol-honk:
needs: [noir-build-acir-tests, configure]
needs: [noir-build-acir-tests, build, configure]
runs-on: ${{ needs.configure.outputs.username }}-x86
if: needs.configure.outputs.barretenberg == 'true' || needs.configure.outputs.noir == 'true'
steps:
Expand All @@ -489,7 +489,7 @@ jobs:
run: earthly-ci --no-output ./+barretenberg-acir-tests-sol-honk

bb-acir-tests-bb-js:
needs: [noir-build-acir-tests, configure]
needs: [noir-build-acir-tests, build, configure]
runs-on: ${{ needs.configure.outputs.username }}-x86
if: needs.configure.outputs.barretenberg == 'true' || needs.configure.outputs.noir == 'true'
steps:
Expand Down

0 comments on commit 1aaee26

Please sign in to comment.