Skip to content

Commit

Permalink
fix: got some public & private calls the wrong way round
Browse files Browse the repository at this point in the history
  • Loading branch information
iAmMichaelConnor committed Jul 29, 2023
1 parent 534a34d commit 06ac22e
Show file tree
Hide file tree
Showing 6 changed files with 6 additions and 6 deletions.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ contract Uniswap {
// inputAsset.withdraw(inputAmount, sender, recipient=l1UniswapPortal, callerOnL1=l1UniswapPortal)
// only uniswap portal can call this (done to safeguard ordering of message consumption)
// ref: https://docs.aztec.network/aztec/how-it-works/l1-l2-messaging#designated-caller
let callStackItem = context.call_public_function(inputAsset, withdrawFnSelector, [
let callStackItem = context.call_private_function(inputAsset, withdrawFnSelector, [
inputAmount,
sender,
l1UniswapPortal,
Expand Down
2 changes: 1 addition & 1 deletion yarn-project/noir-libs/noir-aztec/src/entrypoint.nr
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ impl EntrypointPayload {
if target_address != 0 {
let function_selector = self.flattened_selectors[i];
let args_hash = self.flattened_args_hashes[i];
let _callStackItem = context.call_private_function_with_packed_args(target_address, function_selector, args_hash);
let _callStackItem = context.call_public_function_with_packed_args(target_address, function_selector, args_hash);
}
}
}
Expand Down

0 comments on commit 06ac22e

Please sign in to comment.