Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ejector changes in prep for shutdown. #67

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Ejector changes in prep for shutdown. #67

wants to merge 4 commits into from

Conversation

charlielye
Copy link
Contributor

@charlielye charlielye commented Mar 27, 2024 •
edited
Loading

Not sure if we'll merge this to master yet. Might be a hassle to make tests and things pass. May not be worth it given it's being shutdown. Or could merge to to master but we'll switch CI off anyway. Let's see.

For now the most important things to check:

  • The removal of the escape hatch window check in processRollup in the contract for RollupProcessorV3.
  • The hard limit on rollup size within the circuits (while maintaining a logical 1024 tx topology).

Rumata888
Rumata888 reviewed Mar 27, 2024
View reviewed changes
Copy link
Contributor

@Rumata888 Rumata888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any issues with barretenberg or changes in the proof construction. The other stuff is more familiar to Lasse

benesjan
benesjan reviewed Mar 28, 2024
View reviewed changes
Copy link
Contributor

@benesjan benesjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the Solidity stuff and all the changes look good to me.

@LHerskind
Copy link
Contributor

Changed some of the solidity and Jan checked my changes so should also be good from our side 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benesjan benesjan benesjan left review comments

@Rumata888 Rumata888 Rumata888 left review comments

@LHerskind LHerskind Awaiting requested review from LHerskind

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@charlielye @LHerskind @Rumata888 @benesjan