-
-
Notifications
You must be signed in to change notification settings - Fork 679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FMG 2.0: Codebase refactoring and modernization #842
base: master
Are you sure you want to change the base?
Conversation
It's not necessary at all. But that is one-time action that will allow a lot of cool things in the future. It also forces to write a better code and think a lot about the structure |
This change is really welcome! Thanks for your hard work, that must be
painful.
I'm interested in vite's on demand refresh feature. How can I kick in
easily ? (Which template to use if any, are there any pitalls to avoid?)
Azgaar ***@***.***> ezt írta (időpont: 2022. jún. 26., Vas
11:12):
… It's not necessary at all. But that is one-time action that will allow a
lot of cool things in the future. It also forces to write a better code and
think a lot about the structure
—
Reply to this email directly, view it on GitHub
<#842 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAUMDVONUGBMHYIPMYBWTWDVRANJJANCNFSM5ZZCTPXA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Do you mean hot module replacement? If so, it works just fine out of the box. The template I used is a very basic vanilla-js + typescript: |
Yes, that one.
Azgaar ***@***.***> ezt írta (időpont: 2022. jún. 26., Vas
11:53):
… Do you mean hot module replacement? If so, it works just fine out of the
box.
The template I used is a very basic vanilla-js + typescript:
https://stackblitz.com/edit/vitejs-vite-epqe9h?file=index.html&terminal=dev
—
Reply to this email directly, view it on GitHub
<#842 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAUMDVJZFY2KYZXJNVCCEJ3VRASCBANCNFSM5ZZCTPXA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
data will be seperated later
This reverts commit f90652b.
delete cell-info.d.ts in favor of temporary js import
* updated byId with typing and optional null check * apply new byId
options.ts + byId with types
Hey let me lead with. This tool is incredible it is the number 1 tool I use to run my Pathfinder campaign. I was about to open an Issue called Looks like the right direction to take the project and a huge amount of effort. reply here if you wanna start a thread I'll see it if its in the next few days |
Hello. There is modernization work going on almost every day. But it turned out that the idea or a full migration is too complex, so currently I prefer to implement smaller changes. Once all separate aspects are there, I will consider getting back to migration to modern build tools and TS. |
Description
Starting working on a major code refactoring and modernization.
Goals:
Contract changes as of today
Regiments:
state.military
is renamed tostate.regiments
Routes:
pack.cells.road
is renamed topack.cells.route
pack.cells.route
values are repurposed, now 1 meansroad
, 2 -trail
, 3 -seaRoute
pack.routes
now stores all relevant routes dataDiplomacy:
pack.states[0].diplomacy
pack.states[x].campaigns
=> Both are now stored as an array in
pack.events.conflicts
Provinces:
pack.states[x].provinces
is removed. Now states don't store info about their provincesLabels:
text-anchor
for '#labels' element is changed from 'start' tomiddle
. All childtspan
elements now should have attributex
equal to0
instead of a calculated valueType of change
Versioning