-
-
Notifications
You must be signed in to change notification settings - Fork 655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional points of interest #769
Conversation
modules/markers-generator.js
Outdated
{type: "ruins", icon: "🏺", min: 80, each: 1200, multiplier: 1, list: listRuins, add: addRuins}, | ||
{type: "circuses", icon: "🎪", min: 80, each: 1000, multiplier: 1, list: listCircuses, add: addCircuses}, | ||
{type: "jousts", icon: "🤺", dx: 48, min: 1, each: 25, multiplier: 1, list: listJousts, add: addJousts}, | ||
{type: "canoes", icon: "🛶", min: 20, each: 250, multiplier: 1, list: listCanoes, add: addCanoes}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit weird. Can we get it super rare?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This being jousts, reviews and circuses?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jousts at least get rarity from only being spawnable in burgs with 20+ pop points
Thanks for the contribution! I really like the changes and want them to be merged with just minor corrections |
Please let me know when you think the PR is ready for merging |
I think it should be good now |
Merged. Thanks for the contribution! |
* A bit variety of points of interest added * live-server now running, can actually bash things out * some typos and mirage * suggestions * Rarity changes and capitalisation * Jousts only ever spawn one per map Co-authored-by: Andrew Rose <[email protected]> Co-authored-by: Azgaar <[email protected]>
Hi, I ended up writing these as additional PoI to be generated as something I'm doing while trying to learn some JS. It's seemed to not have any problems with them when I've run it on my machine, but I'm very happy to get additional feedback or whatever, haven't contributed before so don't know the ettiquette at all.