Additional points of interest #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Azgaar
requested changes
Apr 12, 2022
modules/markers-generator.js
Outdated
| {type: "ruins", icon: "🏺", min: 80, each: 1200, multiplier: 1, list: listRuins, add: addRuins}, | ||
| {type: "circuses", icon: "🎪", min: 80, each: 1000, multiplier: 1, list: listCircuses, add: addCircuses}, | ||
| {type: "jousts", icon: "🤺", dx: 48, min: 1, each: 25, multiplier: 1, list: listJousts, add: addJousts}, | ||
| {type: "canoes", icon: "🛶", min: 20, each: 250, multiplier: 1, list: listCanoes, add: addCanoes}, |
There was a problem hiding this comment.
A bit weird. Can we get it super rare?
There was a problem hiding this comment.
This being jousts, reviews and circuses?
There was a problem hiding this comment.
Jousts at least get rarity from only being spawnable in burgs with 20+ pop points
|
Thanks for the contribution! I really like the changes and want them to be merged with just minor corrections |
added 2 commits
April 12, 2022 22:01
|
Please let me know when you think the PR is ready for merging |
|
I think it should be good now |
Azgaar
approved these changes
Apr 15, 2022
|
Merged. Thanks for the contribution! |
sofronaspe
pushed a commit
to sofronaspe/Fantasy-Map-Generator
that referenced
this pull request
Nov 22, 2022
* A bit variety of points of interest added * live-server now running, can actually bash things out * some typos and mirage * suggestions * Rarity changes and capitalisation * Jousts only ever spawn one per map Co-authored-by: Andrew Rose <[email protected]> Co-authored-by: Azgaar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I ended up writing these as additional PoI to be generated as something I'm doing while trying to learn some JS. It's seemed to not have any problems with them when I've run it on my machine, but I'm very happy to get additional feedback or whatever, haven't contributed before so don't know the ettiquette at all.