-
-
Notifications
You must be signed in to change notification settings - Fork 655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Api-Like map save option #730
Conversation
Will be updated and set to a scheme
Hello. Look good! I would prefer to have it as a separate js file and a part of Export UI (not Save). We already have export to GeoJSON (for some data), having a JSON will be a good options as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Request to:
- Move UI to the Export dialog
- Move code to a separate file (e.g.
export-json.js
)
Moved json export to another file named export-json.js
I already read the data model and made the output file based on the data model. Since wiki page says pack contains repackaged data I made exporting based on pack data. Output file contains:
But i am not sure about exporting cell data of pack because cell data is too big. Maybe we can export cell data as different file. |
- all JSON : exports all json data. - minimal JSON : exports json data without cells data. - cells JSON : exports json data only with pack.cells data.
Looks good, I would like to make minor UI changes after the merge. |
I have cleaned up the code and changed the output a bit. Please let me know if it works. |
I test some json data with java with json-simple and it works really good. But i think there should be a export type for grid data. Because some graphical data depends on it. Should app export graphical datas like that with json or some other file |
You can add it in another PR, I would be glad to review |
* Added Save Option for Api-like json export. Will be updated and set to a scheme * Save Option for Api-like added * Moved UI of json export to export dialog. Moved json export to another file named export-json.js * Added Seperated json export selections - all JSON : exports all json data. - minimal JSON : exports json data without cells data. - cells JSON : exports json data only with pack.cells data. * More Stable Cell Export...
Added a option for saving files that looks like a json api response. Can be used easily by programmers.
The result json can look like, this is just an example original output will be different. :