fix: check scheme before setting

Azgaar · Mar 24, 2024 · af927ed · af927ed
1 parent ff39143
commit af927ed
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 8 deletions.
diff --git a/index.html b/index.html
@@ -8093,7 +8093,7 @@
     <script defer src="libs/rgbquant.min.js"></script>
     <script defer src="libs/jquery.ui.touch-punch.min.js"></script>
     <script defer src="modules/io/save.js?v=1.96.00"></script>
-    <script defer src="modules/io/load.js?v=1.97.02"></script>
+    <script defer src="modules/io/load.js?v=1.97.04"></script>
     <script defer src="modules/io/cloud.js?v=1.96.00"></script>
     <script defer src="modules/io/export.js?v=1.97.03"></script>
 

diff --git a/modules/dynamic/auto-update.js b/modules/dynamic/auto-update.js
@@ -743,7 +743,7 @@ export function resolveVersionConflicts(version) {
 
     const opacity = terrs.attr("opacity");
     const filter = terrs.attr("filter");
-    const scheme = terrs.attr("scheme");
+    const scheme = terrs.attr("scheme") || "bright";
     const terracing = terrs.attr("terracing");
     const skip = terrs.attr("skip");
     const relax = terrs.attr("relax");

diff --git a/modules/io/load.js b/modules/io/load.js
@@ -456,16 +456,16 @@ async function parseLoadedData(data, mapVersion) {
     {
       // dynamically import and run auto-update script
       const versionNumber = parseFloat(params[0]);
-      const {resolveVersionConflicts} = await import("../dynamic/auto-update.js?v=1.97.00");
+      const {resolveVersionConflicts} = await import("../dynamic/auto-update.js?v=1.97.04");
       resolveVersionConflicts(versionNumber);
     }
 
     // add custom heightmap color scheme if any
     if (heightmapColorSchemes) {
-      const oceanScheme = terrs.select("#oceanHeights").attr("scheme");
-      const landScheme = terrs.select("#landHeights").attr("scheme");
-      if (!(oceanScheme in heightmapColorSchemes)) addCustomColorScheme(oceanScheme);
-      if (!(landScheme in heightmapColorSchemes)) addCustomColorScheme(landScheme);
+      const oceanScheme = byId("oceanHeights")?.getAttribute("scheme");
+      if (oceanScheme && !(oceanScheme in heightmapColorSchemes)) addCustomColorScheme(oceanScheme);
+      const landScheme = byId("#landHeights")?.getAttribute("scheme");
+      if (landScheme && !(landScheme in heightmapColorSchemes)) addCustomColorScheme(landScheme);
     }
 
     {

diff --git a/versioning.js b/versioning.js
@@ -1,7 +1,7 @@
 "use strict";
 
 // version and caching control
-const version = "1.97.03"; // generator version, update each time
+const version = "1.97.04"; // generator version, update each time
 
 {
   document.title += " v" + version;