Skip to content

Commit

Permalink
Add the name of culture and namesbase in the name editor dialog
Browse files Browse the repository at this point in the history
Added the name of the culture and  namesbase in the dialog "name editor".
This tells information on the "click to generate a culture-specific name"
It tells you the culture before changing name.
  • Loading branch information
Avengium committed Jan 3, 2024
1 parent 845dc89 commit 44673c2
Show file tree
Hide file tree
Showing 3 changed files with 24 additions and 6 deletions.
9 changes: 8 additions & 1 deletion index.html
Original file line number Diff line number Diff line change
Expand Up @@ -4612,7 +4612,7 @@
<span data-tip="Speak the name. You can change voice and language in options" class="speaker">🔊</span>
<span
id="provinceNameEditorShortCulture"
data-tip="Generate culture-specific name"
data-tip="Generate culture-specific name for the province"
class="icon-book pointer"
></span>
<span id="provinceNameEditorShortRandom" data-tip="Generate random name" class="icon-globe pointer"></span>
Expand Down Expand Up @@ -4688,6 +4688,13 @@
class="icon-arrows-cw pointer"
></span>
</div>

<div id="provinceCultureName" data-tip="Dominant culture in the province. This decides the naming criteria">
Province culture:&nbsp;<span id="provinceCultureDisplay"></span>
</div>
<div id="provinceCultureBaseName" data-tip="Namesbase used by the dominant culture in the province.">
Province language:&nbsp;<span id="provinceLanguageDisplay"></span>
</div>
</div>

<div id="namesbaseEditor" class="dialog stable textual" style="display: none">
Expand Down
4 changes: 2 additions & 2 deletions modules/dynamic/editors/states-editor.js
Original file line number Diff line number Diff line change
Expand Up @@ -434,13 +434,13 @@ function editStateName(state) {
modules.editStateName = true;

// add listeners
byId("stateNameEditorShortCulture").on("click", regenerateShortNameCuture);
byId("stateNameEditorShortCulture").on("click", regenerateShortNameCulture);
byId("stateNameEditorShortRandom").on("click", regenerateShortNameRandom);
byId("stateNameEditorAddForm").on("click", addCustomForm);
byId("stateNameEditorCustomForm").on("change", addCustomForm);
byId("stateNameEditorFullRegenerate").on("click", regenerateFullName);

function regenerateShortNameCuture() {
function regenerateShortNameCulture() {
const state = +stateNameEditor.dataset.state;
const culture = pack.states[state].culture;
const name = Names.getState(Names.getCultureShort(culture), culture);
Expand Down
17 changes: 14 additions & 3 deletions modules/ui/provinces-editor.js
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,7 @@ function editProvinces() {
// move all burgs to a new state
province.burgs.forEach(b => (burgs[b].state = newStateId));

// difine new state attributes
// define new state attributes
const {cell: center, culture} = burgs[burgId];
const color = getRandomColor();
const coa = province.coa;
Expand Down Expand Up @@ -500,6 +500,12 @@ function editProvinces() {
document.getElementById("provinceNameEditorShort").value = p.name;
applyOption(provinceNameEditorSelectForm, p.formName);
document.getElementById("provinceNameEditorFull").value = p.fullName;

const cultureName = pack.cultures[pack.cells.culture[pack.provinces[province].center]].name; // to display the culture name
const provinceLangID = pack.cultures[pack.cells.culture[pack.provinces[province].center]].base;
const provinceNameBase = Names.getNameBases()[provinceLangID].name;
document.getElementById("provinceCultureDisplay").innerText = cultureName;
document.getElementById("provinceLanguageDisplay").innerText = provinceNameBase;

$("#provinceNameEditor").dialog({
resizable: false,
Expand All @@ -520,12 +526,17 @@ function editProvinces() {
modules.editProvinceName = true;

// add listeners
document.getElementById("provinceNameEditorShortCulture").addEventListener("click", regenerateShortNameCuture);
document.getElementById("provinceNameEditorShortCulture").addEventListener("click", regenerateShortNameCulture);
document.getElementById("provinceNameEditorShortRandom").addEventListener("click", regenerateShortNameRandom);
document.getElementById("provinceNameEditorAddForm").addEventListener("click", addCustomForm);
document.getElementById("provinceNameEditorFullRegenerate").addEventListener("click", regenerateFullName);

document.getElementById("provinceNameEditorShortCulture").addEventListener("mouseover", showdatatipNamesbase);
function showdatatipNamesbase() {
tip("namesbase " + this.id + Names.getNameBases()[provinceCultureID].name);
}

function regenerateShortNameCuture() {
function regenerateShortNameCulture() {
const province = +provinceNameEditor.dataset.province;
const culture = pack.cells.culture[pack.provinces[province].center];
const name = Names.getState(Names.getCultureShort(culture), culture);
Expand Down

0 comments on commit 44673c2

Please sign in to comment.