New Data Source: wiz_kubernetes_clusters #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gramsa49
reviewed
Dec 14, 2022
| KubernetesClusters vendor.KubernetesClusters `json:"kubernetesClusters"` | ||
| } | ||
|
|
||
| func dataSourceKubernetesClusters() *schema.Resource { |
There was a problem hiding this comment.
Rename to dataSourceWizKubernetesClusters
Suggested change
| func dataSourceKubernetesClusters() *schema.Resource { | |
| func dataSourceWizKubernetesClusters() *schema.Resource { |
gramsa49
reviewed
Dec 14, 2022
internal/provider/provider.go
Outdated
| "wiz_cloud_accounts": dataSourceWizCloudAccounts(), | ||
| "wiz_cloud_config_rules": dataSourceWizCloudConfigurationRules(), | ||
| "wiz_host_config_rules": dataSourceWizHostConfigurationRules(), | ||
| "wiz_kubernetes_clusters": dataSourceKubernetesClusters(), |
There was a problem hiding this comment.
Refactoring
Suggested change
| "wiz_kubernetes_clusters": dataSourceKubernetesClusters(), | |
| "wiz_kubernetes_clusters": dataSourceWizKubernetesClusters(), |
gramsa49
reviewed
Dec 14, 2022
internal/vendor/wiz.go
Outdated
Comment on lines
2151
to
2152
| // KubernetesClusters struct | ||
| type KubernetesClusters struct { |
There was a problem hiding this comment.
This is represented in the GraphQL schema as KubernetesClusterConnection. Rename to match GraphQL schema. This will simplify correlation for future developers and avoid future name conflicts.
kubernetesCluster Query:
type Query {
kubernetesClusters(after: String, filterBy: KubernetesClusterFilters, first: Int): KubernetesClusterConnection!
Suggested change
| // KubernetesClusters struct | |
| type KubernetesClusters struct { | |
| // KubernetesClusterConnection struct | |
| type KubernetesClusterConnection struct { |
gramsa49
reviewed
Dec 14, 2022
|
|
||
| // ReadKubernetesClusters struct | ||
| type ReadKubernetesClusters struct { | ||
| KubernetesClusters vendor.KubernetesClusters `json:"kubernetesClusters"` |
There was a problem hiding this comment.
Refactor the type from KubernetesClusters to KubernetesClusterConnection.
Suggested change
| KubernetesClusters vendor.KubernetesClusters `json:"kubernetesClusters"` | |
| KubernetesClusters vendor.KubernetesClusterConnection `json:"kubernetesClusters"` |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Data Source: wiz_kubernetes_clusters (closes #51)