New Data Source: wiz_users #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gramsa49
reviewed
Dec 14, 2022
internal/vendor/wiz.go
Outdated
Comment on lines
2133
to
2172
| // Users struct | ||
| type Users struct { |
There was a problem hiding this comment.
This is representative of UserConnection from the GraphQL schema.
The users Query from the GraphQL schema returns a UserConnection:
type Query {
users(after: String, filterBy: UserFilters, first: Int): UserConnection!
}
This should be renamed to match the GraphQL type to aid in future development and avoid namespace conflicts.
type UserConnection {
edges: [UserEdge!]
exportUrl(format: ExportFormats = CSV, limit: Int = 5000): String
nodes: [User!]
pageInfo: PageInfo!
totalCount: Int!
}
Suggested change
| // Users struct | |
| type Users struct { | |
| // UserConnection struct | |
| type UserConnection struct { |
There was a problem hiding this comment.
Good catch, will update
gramsa49
reviewed
Dec 14, 2022
|
|
||
| // ReadUsers struct | ||
| type ReadUsers struct { | ||
| Users vendor.Users `json:"users"` |
There was a problem hiding this comment.
Refactor type from Users to UserConnection.
Suggested change
| Users vendor.Users `json:"users"` | |
| Users vendor.UserConnection `json:"users"` |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Data Source: wiz_users (closes #48)
Adding a new data source for wiz_users to retrieve local and idp-backed user details