bugfix/wiz_control_associations: fix for issue#34 #163
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a bug fix for issue#34. A couple of things were happening:
Diffs were appearing even for the same control ID values in the same order
I am not entirely sure yet why this is the case. Supposedly terraform will not present a diff if the values and their order are the same. I think terraform is presenting a diff
because of some internal state that shows the resource data is getting modified at all. So we gate the call to
d.Set("control_ids")
on the presence of actualdifferences in the
cleanControls
and the resource data's control IDs.ForceNew was forcing destruction of association
I am not entirely sure why
ForceNew
is even necessary since the association isn't a real resource, and just calls theUpdateControl
mutation on the wiz GraphQL API. And that update certainly happens in-place, rather than requiring a complete re-creation.