Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Property for disabling an extension #53

Closed
dmurat opened this issue May 29, 2020 · 4 comments
Closed

Property for disabling an extension #53

dmurat opened this issue May 29, 2020 · 4 comments

Comments

@dmurat
Copy link

dmurat commented May 29, 2020

Can you consider adding a property that will disable tracing?

It might be more convenient than poking around with dependencies if tracing, for some reason, isn't desired in different environments (dev, qa, prod, etc.).

Tnx.

@dmurat
Copy link
Author

dmurat commented May 30, 2020

Found a way via spring.autoconfigure.exclude:

spring.autoconfigure.exclude:
  - org.axonframework.extensions.tracing.autoconfig.TracingAutoConfiguration

@dmurat dmurat closed this as completed May 30, 2020
@abuijze abuijze reopened this May 30, 2020
@abuijze
Copy link
Member

abuijze commented May 30, 2020

Reopening, because I agree with you. Deselecting it from the auto configuration is a workaround IMHO. You shouldn’t have to be aware of the class names in the extension.

@dmurat
Copy link
Author

dmurat commented May 31, 2020

Great :-)

FYI, I tried this extension with Spring Boot 2.3.0 and its Wavefront integration with build-in tracing, and it works perfectly :-)

@smcvb
Copy link
Member

smcvb commented Aug 17, 2020

Closing this issue as it has been resolved in pull request #55.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants