Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add implementation and tests for the JobRunrProDeadlineManager. #10

Merged
merged 15 commits into from
Mar 3, 2023
Merged

Add implementation and tests for the JobRunrProDeadlineManager. #10

merged 15 commits into from
Mar 3, 2023

Conversation

gklijs
Copy link

@gklijs gklijs commented Feb 17, 2023

It needs the correct credentials and AxonFramework/AxonFramework#2564 to be merged before it will build.

@gklijs gklijs added this to the 4.8.0 milestone Feb 17, 2023
@gklijs gklijs self-assigned this Feb 17, 2023
This was referenced Feb 17, 2023
Closed
Merged
@smcvb smcvb requested review from a team, CodeDrivenMitch and smcvb and removed request for a team February 22, 2023 10:32
smcvb
smcvb requested changes Feb 22, 2023
View reviewed changes
Copy link
Member

@smcvb smcvb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mainly small fry, but one pointer that's worth discussing: do we really need a JobRunrProEventScheduler?

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
...java/org/axonframework/extensions/jobrunrpro/autoconfig/AxonJobRunrProAutoConfiguration.java Outdated Show resolved Hide resolved
...rc/main/java/org/axonframework/extensions/jobrunrpro/deadline/JobRunrProDeadlineManager.java Outdated Show resolved Hide resolved
jobrunrpro/src/main/java/org/axonframework/extensions/jobrunrpro/util/JobRunrProUtils.java Show resolved Hide resolved
...a/org/axonframework/extensions/jobrunrpro/deadline/JobRunrProDeadlineManagerBuilderTest.java Outdated Show resolved Hide resolved
.../org/axonframework/extensions/jobrunrpro/scheduling/JobRunrProEventSchedulerBuilderTest.java Outdated Show resolved Hide resolved
.../org/axonframework/extensions/jobrunrpro/scheduling/JobRunrProEventSchedulerBuilderTest.java Outdated Show resolved Hide resolved
...a/org/axonframework/extensions/jobrunrpro/deadline/JobRunrProDeadlineManagerBuilderTest.java Outdated Show resolved Hide resolved
@smcvb
Update README.md
9818279 
Co-authored-by: Steven van Beelen <[email protected]>
@CLAassistant
Copy link

CLAassistant commented Feb 24, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

Gerard Klijs and others added 9 commits February 24, 2023 09:34
@smcvb
Update jobrunrpro-spring-boot-autoconfigure/src/main/java/org/axonfra…
896780b 
…mework/extensions/jobrunrpro/autoconfig/AxonJobRunrProAutoConfiguration.java

Co-authored-by: Steven van Beelen <[email protected]>
@smcvb
Update jobrunrpro/src/test/java/org/axonframework/extensions/jobrunrp…
3ec0ea3 
…ro/deadline/JobRunrProDeadlineManagerBuilderTest.java

Co-authored-by: Steven van Beelen <[email protected]>
@smcvb
Update jobrunrpro/src/test/java/org/axonframework/extensions/jobrunrp…
ea845ce 
…ro/scheduling/JobRunrProEventSchedulerBuilderTest.java

Co-authored-by: Steven van Beelen <[email protected]>
Remove the JobRunrProEventScheduler
9eacf39
Improvement, mostly adding and moving tests, based on the pr.
fde8967
Add axon-spring test dependency for the `AbstractDeadlineManagerTestS…
429df19 
…uite`.
Fix the tests.
d3549f4
Harden test preventing false positive.
2afcfe0
Remove two code smells.
2daedfb
CodeDrivenMitch
CodeDrivenMitch approved these changes Feb 27, 2023
View reviewed changes
Copy link
Member

@CodeDrivenMitch CodeDrivenMitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 small comments, otherwise looks good to me 👍

@gklijs gklijs changed the title Add implementation and tests for the JobRunrProEventScheduler and JobRunrProDeadlineManager. Add implementation and tests for the JobRunrProDeadlineManager. Mar 1, 2023
smcvb
smcvb approved these changes Mar 3, 2023
View reviewed changes
Copy link
Member

@smcvb smcvb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small fry remaining. Other than that, I think this looks good 👍

README.md Outdated Show resolved Hide resolved
.../org/axonframework/extensions/jobrunrpro/autoconfig/AxonJobRunrProAutoConfigurationTest.java Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Gerard Klijs and others added 3 commits March 3, 2023 13:46
@smcvb
Update README.md
0ab0270 
Co-authored-by: Steven van Beelen <[email protected]>
@smcvb
Update jobrunrpro-spring-boot-autoconfigure/src/test/java/org/axonfra…
4bdf06c 
…mework/extensions/jobrunrpro/autoconfig/AxonJobRunrProAutoConfigurationTest.java

Co-authored-by: Steven van Beelen <[email protected]>
@smcvb
Update README.md
1e93915 
Co-authored-by: Steven van Beelen <[email protected]>
@gklijs gklijs merged commit d2de80c into main Mar 3, 2023
@gklijs gklijs deleted the init branch March 3, 2023 12:47
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smcvb smcvb smcvb approved these changes

@CodeDrivenMitch CodeDrivenMitch CodeDrivenMitch approved these changes

Assignees

@gklijs gklijs

Labels
Priority 1: Must Status: Resolved Type: Enhancement
Projects
None yet
Milestone
Release 4.8.0
Development

Successfully merging this pull request may close these issues.
4 participants
@gklijs @CLAassistant @CodeDrivenMitch @smcvb