Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type hints to handshake, inverse, mathematicalconstants #858

Merged
merged 8 commits into from
Feb 10, 2017

Conversation

janga1997
Copy link
Member

#808
Only one error in mypy, regarding the file mathematicalconstants.py
We are importing e from the math module and defining a class e too, which is raising some errors.
What would you like the class e(CotoDeRatio): to be renamed to?
@marcharper @drvinceknight @Nikoleta-v3

@drvinceknight
Copy link
Member

What would you like the class e(CotoDeRatio): to be renamed to?

Don't rename the e class simply change the imports to be:

import math

and then use math.e, math.pi etc...

@drvinceknight
Copy link
Member

@marcharper @drvinceknight @Nikoleta-v3

Also: there's no need to ping us all. The core developers get notifications.

@janga1997
Copy link
Member Author

Sorry about the pinging. Won't happen again.

@marcharper
Copy link
Member

You can ping us if you need to just know that we already get notifications for every PR and every comment/update. We're also in very different time zones.

@drvinceknight
Copy link
Member

@janga1997 it looks like this is forked from your short mem player (https://github.com/Axelrod-Python/Axelrod/pull/858/files#diff-a964005e2620fada6accc62bb679e816)? So merging this would include that player too but we're still discussing that on #857.

@drvinceknight drvinceknight merged commit bce4f70 into Axelrod-Python:master Feb 10, 2017
@janga1997 janga1997 deleted the typeHint5 branch February 10, 2017 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants