Refactor Player.__new__ to automatically apply init_args #817
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've eliminated the need for
@init_args
by modifyingPlayer.__new__
and eliminated most usage ofinit_args
in the library.Player.__new__
now caches theargs
andkwargs
passed to__init__
. There's no need to explicitly use the decorator except for one case inLookerUp
where the classes are created dynamically at runtime, but it may be possible to eliminate that as well.@meatballs This may solve your issue on #706, and if not, it should be easier to fix now.