Soft tf2t: rebase #650
Soft tf2t: rebase #650
Conversation
|
Unless I'm misunderstanding the strategy you have written is already implemented as Is that right @ranjinidas ? |
| if len(self.history) == 0: | ||
| return C | ||
|
|
||
| if opponent.history[-2] == [D, D]: |
There was a problem hiding this comment.
I think you wanted this to be opponent.history[-2:] == [D, D] so that it sliced the list. Otherwise opponent.history[-2] is just the second from last element which would either be C or D.
|
If you'd like a hand at all feel free to jump in to the chat room here: https://gitter.im/Axelrod-Python/Axelrod There's usually a couple of us around and we're happy to help :) |
|
Hi Vince and Marc, Thanks for your replies! I didn't realize Tit for Two Tats and Slow Tit for I'm a beginner in Python and OSS, and I will try again with another Best, On Wed, Jul 6, 2016 at 10:24 AM, Vince Knight [email protected]
|
|
As far as I can tell soft tit for two tats isn't there but slow tit for 2 tats is and is defined as:
Looking through your commits, it looks like you started writing this strategy here: d4dbe8a (you can click on that) but then you changed it here: 3ee3876 to become tit for 2 tats.
I think implementing slow tit for 2 tats is probably a good choice of strategy :) We're happy to help out :) |
|
@drvinceknight Thanks for the feedback. :) I'll go back to working on that strategy. |
|
Closing this as it's superseded by #659 (we can always open it again if need be). |
Hi @ranjinidas : I rebased your branch onto the latest master so that it is easier for us to review. We'll also need to add some tests, but we can take care of that if needed.