-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding remorseful prober #633
Conversation
Done this using a transformer which requires some TLC for the name.
IN GAMES, VOL. 3, NO. 4, DECEMBER 2011 | ||
|
||
A better description is given in the selfish gene: | ||
https://books.google.co.uk/books?id=ekonDAAAQBAJ&pg=PA273&lpg=PA273&dq=remorseful+prober&source=bl&ots=kAeYRYg7GB&sig=RD5-XtDAxzTF9rxRZEWyFjwuKhc&hl=en&sa=X&ved=0ahUKEwiFg--H_qvNAhWXF8AKHQVTAzcQ6AEIKDAC#v=onepage&q=remorseful%20prober&f=false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That url can be shortened to just https://books.google.co.uk/books?id=ekonDAAAQBAJ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good shout, I'll give this a general clean up now :)
and Graham Kendall. IEEE TRANSACTIONS ON COMPUTATIONAL INTELLIGENCE AND AI | ||
IN GAMES, VOL. 3, NO. 4, DECEMBER 2011 | ||
|
||
A fuller description is given in "The Selfish Gene" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fuller more complete
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup.
This is a side conversation but you can have a player track its own intended history and then compare to its stored history without modifying the |
I had a couple of comments but they are minor so feel free to merge with or without making any changes. |
So this would be helpful for contrite TFT right? |
Don't merge yet: will give the test helper functions a better go. |
I presume so! |
Am I missing something here:
Commenting out lines 200 -> 204 and replacing with 205 -> 205 (as above) do not give the same result:
Looking at the source code it certainly should be, any ideas? |
Ignore me. That was a stupid question (I was misreading). |
But this diff should give the same behaviour right?
It does not: the second test does not show remorse. I think the helper functions are doing something in the background that I don't understand (and becoming less of a fan of...). Am I just missing something and getting myself confused? |
I've pushed 27a065e with the above diff. The tests fail. |
This reverts commit 27a065e.
ba1cce5 reverts the commit that fails. I'll leave it there in case it's helpful and/or an issue needs to be raised (does something need to be better documented?) but I'm happy (if everyone else is) for this to be merged as is. Not using the helper functions is my preference (I think): it's verbose and explicit. |
Your tests are fine. I'll take a closer look at the |
This is the remaining strategy for the list from #387. There is another strategy on that list "contrite tft" but that strategy actually needs to know when a move against it was caused by noise. I suggest (after this) we close #387 and open another issue for that strategy as it will need a bit of a tweak to the
Match
class (or something).Note that for some of the tests for this strategy I'm not using the helper functions. I didn't seem able to get the required behaviour with them: I got myself a big confused so found it easier to use the verbose calls. Not averse to spending time getting the helper functions working if we are keen to...