-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move processes argument from Tournament.__init__ to tournament.play #582
Conversation
The build fails on Python 3.4 while building matplotlib, I suspect it's just a travis problem. |
Have kicked off the build again. I like that you've moved repetitions also. |
Actually it just looks that way from the diff, but it could be a good idea to move repetitions as well. |
Oh yeah! I see that now :) As it's needed for the generator actually perhaps leave it? (haven't had coffee yet) in a way that is part of the tournament and I can imagine a tournament generator that samples the repetitions for each match? |
Let's think about it for another PR. |
Yup. Weird the build failed to install matplotlib again... Have set it off again, I'll take a proper look this morning. I'm guessing it's some temporary problem with Travis.... |
I can't see any reason why it would fail on just 3.4, so my next thought was some kind of Travis issue as well. |
It's not getting to the code right, just failing to install matplotlib. For sure a Travis issue... |
#585 should fix the py3.4 bug (issue with an upstream bug in pyparsing). |
👍 from me once py3.4 is happy. |
Correcting the hypothesis decorators. (Not for master)
Re #580