Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move processes argument from Tournament.__init__ to tournament.play #582

Merged
merged 5 commits into from
May 12, 2016

Conversation

marcharper
Copy link
Member

Re #580

@marcharper
Copy link
Member Author

The build fails on Python 3.4 while building matplotlib, I suspect it's just a travis problem.

@drvinceknight
Copy link
Member

Have kicked off the build again. I like that you've moved repetitions also.

@marcharper
Copy link
Member Author

Actually it just looks that way from the diff, but it could be a good idea to move repetitions as well.

@drvinceknight
Copy link
Member

Oh yeah! I see that now :) As it's needed for the generator actually perhaps leave it? (haven't had coffee yet) in a way that is part of the tournament and I can imagine a tournament generator that samples the repetitions for each match?

@marcharper
Copy link
Member Author

Let's think about it for another PR.

@drvinceknight
Copy link
Member

Yup. Weird the build failed to install matplotlib again... Have set it off again, I'll take a proper look this morning. I'm guessing it's some temporary problem with Travis....

@marcharper
Copy link
Member Author

I can't see any reason why it would fail on just 3.4, so my next thought was some kind of Travis issue as well.

@drvinceknight
Copy link
Member

It's not getting to the code right, just failing to install matplotlib. For sure a Travis issue...

@drvinceknight
Copy link
Member

#585 should fix the py3.4 bug (issue with an upstream bug in pyparsing).

@drvinceknight
Copy link
Member

👍 from me once py3.4 is happy.

@meatballs meatballs merged commit 1501f19 into master May 12, 2016
@meatballs meatballs deleted the 580 branch May 12, 2016 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants