-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a progress bar #578
Conversation
Very nice :) |
@@ -66,7 +68,7 @@ def setup_output_file(self, filename=None): | |||
# Save filename for loading ResultSet later | |||
self.filename = filename | |||
|
|||
def play(self, build_results=True, filename=None): | |||
def play(self, build_results=True, filename=None, progress_bar=None): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If progress_bar is a boolean, why not use False as the default value?
- Progress according to chunks - Works for both parallel and serial Here's a gif showing how this looks: http://g.recordit.co/941gAYzwqh.gif
Good call @meatballs, have made that change (and also added some more tests that check if the progress bar was or wasn't created). |
Have added a line to the docs about the progress bar @meatballs: 08a0bb5 I don't feel strongly about it. Just a thought. Happy to throw it out... |
👍 Vince Knight wrote:
|
It looks good for me, my only comment is that we might want progress bars on by default. Regardless this is 👍 from me. |
I'm easy. Note that with False by default when running the test suite you get 2 or 3 Any preference @meatballs? On Tue, 10 May 2016, 15:38 Marc Harper, [email protected] wrote:
|
How about True by default but the test suite passes in False? |
That would work. I'll do that now on the train. :) On Tue, 10 May 2016, 15:43 Owen Campbell, [email protected] wrote:
|
That's done. A few progress bar still appear (to test that it actually works and doesn't break anything) but most are turned off. |
Closes #558
This is built on top of #572.
Works for both parallel and serial. Here's a gif showing it (code from https://gist.github.com/drvinceknight/2f42efc2388f41d3da7931ffc10aee6f):