Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doctest. <- Better to not merge this - look at #1372 instead. #1371

Closed
wants to merge 1 commit into from

Conversation

drvinceknight
Copy link
Member

@drvinceknight drvinceknight commented Sep 9, 2020

This is the same PR as #1372 but to master. Merging this PR would need a subsequent piece of work before setting dev as the default branch. Don't merge this PR: let's close it and merge #1372 instead. :)

This was failing on #1364
but the fix is trivial.
@drvinceknight drvinceknight changed the title Fix doctest. Fix doctest. <- Better to not merge this - look at #1372 instead. Sep 9, 2020
@Nikoleta-v3
Copy link
Member

👍 I approve to close this.

@drvinceknight
Copy link
Member Author

Closing this as @marcharper and @Nikoleta-v3 have approved #1372

@marcharper marcharper deleted the fix-failing-tests-from-spitefullCC branch July 3, 2022 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants