-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix makes_use_of on MindReader #1331
Fix makes_use_of on MindReader #1331
Conversation
axelrod/strategies/mindreader.py
Outdated
@@ -91,7 +91,7 @@ class MirrorMindReader(ProtectedMindReader): | |||
classifier = { | |||
"memory_depth": float("inf"), | |||
"stochastic": False, | |||
"makes_use_of": set(), | |||
"makes_use_of": {"game"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically this one uses the opponent strategy, so whatever the opponent does determines the classifier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:| Okay, I'm going to revert this back to set(), but I guess there's really not a correct value here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we can add a test that tries variations of the game to see if it changes player behavior? I think we're not too concerned about these cheating strategies since the are excluded from everything, but if we can catch this kind of thing from a test in general that's good.
I would like to not do that. I think it would be difficult to come up with examples. But the code evidently does use game, and it would be hard to imagine a case where this dependency would break. I think other strategies that make use of game don't have similar tests, and I think I also saw that cheating strategies are going to be deprecated, so it may not be worth the trouble. |
The MindReader strategies appear to use game (line 44), so I add this to the classifier.