Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change EvolvablePlayer serialization to write strings instead of bytes #1267

Merged
merged 2 commits into from
Oct 21, 2019
Merged

Change EvolvablePlayer serialization to write strings instead of bytes #1267

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a6d935b
Change EvolvablePlayer serialization to write strings instead of byte…
marcharper Oct 17, 2019
6ac46a8
Add serialization test
marcharper Oct 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions axelrod/evolvable_player.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import base64
from pickle import dumps, loads
from random import randrange
from typing import Dict, List
Expand Down Expand Up @@ -36,12 +37,14 @@ def create_new(self, **kwargs):

def serialize_parameters(self):
"""Serialize parameters."""
return dumps(self.init_kwargs)
pickled = dumps(self.init_kwargs) # bytes
s = base64.b64encode(pickled).decode('utf8') # string
return s

@classmethod
def deserialize_parameters(cls, serialized):
"""Deserialize parameters to a Player instance."""
init_kwargs = loads(serialized)
init_kwargs = loads(base64.b64decode(serialized))
return cls(**init_kwargs)

# Optional methods for evolutionary algorithms and Moran processes.
Expand Down
11 changes: 11 additions & 0 deletions axelrod/tests/strategies/test_evolvable_player.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,17 @@ def test_serialization(self):
self.assertEqual(player, deserialized_player)
self.assertEqual(deserialized_player, deserialized_player.clone())

def test_serialization_csv(self):
"""Serializing and deserializing should return the original player."""
seed(0)
player = self.player()
serialized = player.serialize_parameters()
s = "0, 1, {}, 3".format(serialized)
s2 = s.split(',')[2]
deserialized_player = player.__class__.deserialize_parameters(s2)
self.assertEqual(player, deserialized_player)
self.assertEqual(deserialized_player, deserialized_player.clone())

def behavior_test(self, player1, player2):
"""Test that the evolvable player plays the same as its (nonevolvable) parent class."""
for opponent_class in [axl.Random, axl.TitForTat, axl.Alternator]:
Expand Down