Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Rowsam (k58r) strategy from Axelrod's second. #1228

Merged
merged 7 commits into from
Jan 3, 2019

Conversation

gaffney2010
Copy link
Member

Adapted from https://github.com/Axelrod-Python/TourExec/blob/v0.3.0/src/strategies/k58r.f

In adapting:

  • I called KAM distrust_points.
  • I refactored NPHA in "Coop Def cycle" modes.
  • I changed the K to M comparators in lines 12-15 to a comparison on K/M, which I call points_per_turn.

@marcharper
Copy link
Member

Hi, thanks for the implementation. Do you know how to run the fingerprints for the two implementations (this and the original from axelrod/fortran)? That will help us test the equivalence, which can be tricky otherwise.

Also note that there will likely be some significant delays in review over the holidays.

@gaffney2010
Copy link
Member Author

Yes, I can run them. I'm on command line only until Wednesday; will run it then.

@gaffney2010
Copy link
Member Author

axl_fort
axl_py

Bit of a delay on these; I had trouble getting everything setup.

@marcharper
Copy link
Member

Looks good to me. Is it possible to generate fingerprints against more strategies? I think previously we've tossed in Random(p) for e.g. p in np.arange(0, 1, 0.05) as well.

@gaffney2010
Copy link
Member Author

Here they are.

rand_axl_fort
rand_axl_py

@drvinceknight
Copy link
Member

Apologies for the delay in getting to this, just got back online :)

Looks great and thanks @gaffney2010 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants