Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spruce up fingerprint (mostly AshlockFingerprint) #1205

Merged
merged 1 commit into from
Sep 1, 2018
Merged

Spruce up fingerprint (mostly AshlockFingerprint) #1205

merged 1 commit into from
Sep 1, 2018

Conversation

langner
Copy link
Member

@langner langner commented Sep 1, 2018

  • Prefix internal functions and methods with underscore
  • Test the external API only
  • Be more locally explicit in unit tests (no need for

@langner
Spruce up fingerprint (mostly AshlockFingerprint)
2bb63c9 
* Prefix internal functions and methods with underscores
* Test everything through the external API only
* Be explicit and local in unit tests (no self.strategy and self.probe)
drvinceknight
drvinceknight approved these changes Sep 1, 2018
View reviewed changes
Copy link
Member

@drvinceknight drvinceknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@marcharper marcharper merged commit ff16f77 into Axelrod-Python:master Sep 1, 2018
@langner
Copy link
Member Author

langner commented Oct 21, 2018

Note: this was also for #347

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drvinceknight drvinceknight drvinceknight approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@langner @drvinceknight @marcharper