Fix the data set dimensions for the sdvplot. #1130
Conversation
This closes #1129. I could not find anything in the release notes <http://matplotlib.org/users/whats_new.html> however I think this is due to the fact that mpl 2.1 got rid of the availability to handle the unflatten sub list (so this fix will still work with previous versions of mpl).
|
Investigating why coverage would have dropped... |
This version seems to cover all our needs and is still ensuring coverage. As hypothesis seems to be developing/changing this just makes things easier for us.
axelrod/plot.py
Outdated
| @@ -112,7 +112,8 @@ def _sd_ordering(self): | |||
| @property | |||
| def _sdv_plot_dataset(self): | |||
| ordering = self._sd_ordering | |||
| diffs = self.result_set.score_diffs | |||
| diffs = [[diff for repetition in diffs for diff in repetition] | |||
There was a problem hiding this comment.
This is confusing, can we use different iteration variables?
There was a problem hiding this comment.
I picked these in an attempt to not be confusing but happy to take any suggestions.
There was a problem hiding this comment.
91a3ee8 renames them to what is hopefully less confusing but still happy to change further if you think it can be improved 👍 :)
There was a problem hiding this comment.
It's still a little confusing since player and opponent usually indicate instances of Player classes. But it's better than before in that I can see what it's doing now.
axelrod/tournament.py
Outdated
| @@ -255,8 +255,8 @@ def _run_parallel(self, processes: int=2) -> bool: | |||
| """ | |||
| # At first sight, it might seem simpler to use the multiprocessing Pool | |||
| # Class rather than Processes and Queues. However, this way is faster. | |||
| work_queue = Queue() | |||
| done_queue = Queue() | |||
| work_queue = Queue() # type: Queue | |||
There was a problem hiding this comment.
nit: I think it's supposed to be two spaces before the #.
There was a problem hiding this comment.
Good catch. Have fixed.
|
Merging. Will do a new release :+1 |
This closes #1129.
I could not find anything in the release notes
http://matplotlib.org/users/whats_new.html however I think this is due to the fact that mpl 2.1 got rid of the ability to handle the unflattened sub list (so this fix will still work with previous versions of mpl).