Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A couple of extra progress bars for the fingerprint #768

Closed
drvinceknight opened this issue Nov 19, 2016 · 1 comment
Closed

A couple of extra progress bars for the fingerprint #768

drvinceknight opened this issue Nov 19, 2016 · 1 comment
Assignees
@drvinceknight
Labels
enhancement

Comments

@drvinceknight
Copy link
Member

Would be good to pass the progress bar method to the create_points function and also generate_data. For big fingerprints there is a bit of a lag where there is no user feedback during these phases.

(Also: currently the read_interactions_from_file call is not passed the progress bar argument from the fingerprint method, so when it's used but progress_bar=False it will still display a progress bar.)

These are all minor enhancements.
@drvinceknight drvinceknight self-assigned this Dec 3, 2016
@drvinceknight
Copy link
Member Author

I'll pick this one up. Noticed it whilst doing the fingerprint repo.

drvinceknight added a commit that referenced this issue Dec 3, 2016
@drvinceknight
Add a variety of progress bars to the fingerprint.
451e9bd 
Most are straight forward, for the creation of the points I had to
refactor things slightly (as it's a product of two lists there wasn't a
straightforward way of using tqdm on it).

Closes #768.
@drvinceknight drvinceknight mentioned this issue Dec 3, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@drvinceknight drvinceknight

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@drvinceknight