Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent naming of Lambert W functions #65

Closed
JSorngard opened this issue Jul 30, 2024 · 2 comments
Closed

Inconsistent naming of Lambert W functions #65

JSorngard opened this issue Jul 30, 2024 · 2 comments

Comments

@JSorngard
Copy link
Contributor

JSorngard commented Jul 30, 2024 •
edited
Loading

I just realized that I named the Lambert W functions inconsistently in the prelude implementation: the secondary branch was given the name lambert_w_m1 when it's named lambert_wm1 in fuga.

The fix is easy, just rename the function to lambert_wm1 in prelude, but this would be a breaking change.

It's probably not worth worrying about as the API is different between the prelude and fuga implementations anyway, but I wanted to notify you.
@Axect
Copy link
Owner

Axect commented Jul 30, 2024

Oh, I got it. Thank you for notice.
I'll fix it soon.

Axect added a commit that referenced this issue Jul 30, 2024
@Axect
FIX: Fix prelude's different lambert_wm1 (#65)
a0f6af1
Axect added a commit that referenced this issue Jul 30, 2024
@Axect
RLSE: Ver 0.37.9
686d81d 
- Fix inconsistent lambert w in prelude (#65)
- Write a doc string for special/mod.rs
Axect added a commit that referenced this issue Jul 30, 2024
@Axect
Ver 0.37.9
88ab4f3 
- Fix inconsistent lambert w in prelude (#65)
- Write doc string for special/mod.rs
@Axect
Copy link
Owner

Axect commented Jul 30, 2024

Thanks again for bringing this to our attention.
The issue has been fixed and published in version 0.37.9.
You can check the details in the latest release: v0.37.9

@Axect Axect closed this as completed Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Axect @JSorngard