Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use Post::$databaseId to prevent fatals #109

Merged
merged 1 commit into from
Aug 17, 2024
Merged

fix: use Post::$databaseId to prevent fatals #109

merged 1 commit into from
Aug 17, 2024

Conversation

justlevine
Copy link
Member

What

This PR fixes an issue in NodeWithSeo so the model is resolved using Post::$databaseId instead of Post::$ID

Why

On private posts, the Post::$ID is protected, leading to potential fatal errors with strict types.

Fixes #108

How

Testing Instructions

Additional Info

Checklist:

  • My code is tested to the best of my abilities.
  • My code follows the WordPress Coding Standards.
  • My code has proper inline documentation.
  • I have added unit tests to verify the code works as intended.
  • The changes in this PR have been noted in CHANGELOG.md

@justlevine justlevine merged commit de6c1ce into AxeWP:develop Aug 17, 2024
17 checks passed
@justlevine justlevine deleted the fix/post-model-databaseid branch August 17, 2024 08:52
@justlevine justlevine mentioned this pull request Aug 17, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Querying password protected nodeByUri
1 participant
@justlevine