Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid repeating requirements #7

Merged
merged 4 commits into from
Apr 4, 2018
Merged

Conversation

tunnell
Copy link
Member

@tunnell tunnell commented Apr 4, 2018

Instead of repeating the requirements, you can just read requirements.txt then strip pinned versions. See #6

@JelleAalbers
Copy link
Member

I think you omitted the part that actually strips the pinned versions from the strings. Also requires was used twice but you replaced only one of them, so it doesn't work yet.

This is certainly a solution, but I recall reading some warnings not to parse requirement.txt yourself since it apparently can do a lot of things. Did you find somebody that recommended this?

@tunnell
Copy link
Member Author

tunnell commented Apr 4, 2018

I found it in one of the links you included. The requirements file isn't so complicated, but your call.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 20

  • 0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+3.3%) to 55.518%

Totals Coverage Status
Change from base Build 15: 3.3%
Covered Lines: 493
Relevant Lines: 888

💛 - Coveralls

@tunnell
Copy link
Member Author

tunnell commented Apr 4, 2018

This is ready if you want it

@JelleAalbers
Copy link
Member

Thanks, this seems better than repeating the requirements, especially given that we're still in rapid development.

I think you took pyupio/pyup#137 (comment); from the discussion in that thread I gather this isn't exactly the standard way. On the other hand I'm not ready to go deeper in the woods with packaging at the moment... let's start with this and see when we need more.

@JelleAalbers JelleAalbers merged commit 3b2ed9b into AxFoundation:master Apr 4, 2018
JoranAngevaare added a commit that referenced this pull request Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants