Add UI option to block deleted rooms from being rejoined #166
Conversation
jkanefendt
changed the title
|
Please fix the checks. Try |
|
IMO during creation of this PR was the master broken. Perhaps it is only necessary to merge current master into this branch. |
src/components/rooms.js
Outdated
| export const DeleteRoomButton = props => { | ||
| const classes = useStyles(props); |
There was a problem hiding this comment.
Please extract the DeleteRoomButton together with the DeleteRoomDialog into a separate file, so it can be reused by other views.
|
Is there a plan for the 2nd DeleteButton.? synapse-admin/src/components/rooms.js Lines 314 to 319 in 40d0813 At the moment have both buttons (list and detail view) the same function. |
You mean the option shall be implemented for batch deletes as well? Yes, i agree. I'll try to fix this. |
| @@ -68,7 +68,7 @@ const resourceMap = { | |||
| }, | |||
| delete: params => ({ | |||
| endpoint: `/_synapse/admin/v1/rooms/${params.id}`, | |||
| body: { block: false }, | |||
| body: { block: !!params.block }, | |||
There was a problem hiding this comment.
Need to use params.meta.block in react-admin 4
This is almost a copy of Awesome-Technologies/synapse-admin#166 PR, authored by @jkanefendt
Add UI option to block deleted rooms from being rejoined This is almost a copy of Awesome-Technologies/synapse-admin#166 PR, authored by @jkanefendt
This PR adds a customized delete room dialog with an option to block the deleted room from being rejoined.