meson: Fix deprecation warning #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The library should be passed as first positional argument to pkg.generate(). Also remove arguments that meson sets by default already. This requires meson >= 0.46.0.
|
I'm just eluded by the "deprecation warning": when does it happen? If I simply run |
|
It's a bit complicated... It happens when libavtp is used as subprojects of gstreamer. The reason is when the library is passed as first positional argument meson remembers the PC file is associated with that lib. When later gstreamer generates its own PC file, meson will know to use requires: instead of libs: with this pr. |
|
Oh, I see. That's for the static build, right? |
|
Yes, thanks. I don't have merge permission, can you do it for me please? |
vcgomes
approved these changes
Oct 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The library should be passed as first positional argument to
pkg.generate(). Also remove arguments that meson sets by default
already.
This requires meson >= 0.46.0.