feat: Intellisense XML Comment #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxkatz6
reviewed
Jun 9, 2023
Comment on lines
140
to
144
| var compl = GetCompletionsFor("<DataTemplate"); | ||
|
|
||
| Assert.Equal(2, compl.Completions.Count); | ||
| Assert.Equal("DataTemplate", compl.Completions[0].DisplayText); | ||
| Assert.Equal("DataTemplates", compl.Completions[1].DisplayText); | ||
| Assert.Equal(3, compl.Completions.Count); | ||
| Assert.Equal("DataTemplate", compl.Completions[1].DisplayText); | ||
| Assert.Equal("DataTemplates", compl.Completions[2].DisplayText); |
There was a problem hiding this comment.
Not sure, but is it going to propose to comment the line as a first option here?
There was a problem hiding this comment.
I same behaviour di WPF Editor.
There was a problem hiding this comment.
That's what it shows for me. DataTemplate is selected by default.
There was a problem hiding this comment.
Because VS WPF Editor has type compatibility and collects usage statistics to propose at the head of the suggestions.
I will add these features in the next PRs.
maxkatz6
approved these changes
Jun 9, 2023
# Conflicts: # CompletionEngine/Avalonia.Ide.CompletionEngine/Completion/CompletionEngine.cs # tests/CompletionEngineTests/BasicTests.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.