-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Selector autocompletate #303
feat: Selector autocompletate #303
Conversation
if anyone has time can try it and report any problems. In the tests I'm doing at the moment I haven't found any. |
wait merge #302 |
32e290b
to
ea23d4d
Compare
CompletionEngine/Avalonia.Ide.CompletionEngine/Completion/CompletionEngine.cs
Outdated
Show resolved
Hide resolved
CompletionEngine/Avalonia.Ide.CompletionEngine/Completion/CompletionEngine.cs
Outdated
Show resolved
Hide resolved
CompletionEngine/Avalonia.Ide.CompletionEngine/Completion/CompletionEngine.cs
Show resolved
Hide resolved
CompletionEngine/Avalonia.Ide.CompletionEngine/Completion/Completion.cs
Outdated
Show resolved
Hide resolved
CompletionEngine/Avalonia.Ide.CompletionEngine/Completion/CompletionEngine.cs
Outdated
Show resolved
Hide resolved
CompletionEngine/Avalonia.Ide.CompletionEngine/Completion/CompletionEngine.cs
Show resolved
Hide resolved
@amwx |
6983321
to
f9d9d2e
Compare
Found a few issues:
What I think is happening here, (line 374 in CompletionEngine), you're calculating the current start for the autocompletion as
Edit: Oh, also I got a random |
CompletionEngine/Avalonia.Ide.CompletionEngine/Completion/CompletionEngine.cs
Outdated
Show resolved
Hide resolved
CompletionEngine/Avalonia.Ide.CompletionEngine/Completion/CompletionEngine.cs
Outdated
Show resolved
Hide resolved
4979a46
to
fd7926d
Compare
d0a5cdd
to
b779b25
Compare
From above: 2- Still not fixed (names aren't auto selected) 3- Still not fixed (no suggestions are offered after a property unless you hit space) 4- fixed |
b779b25
to
3e8684d
Compare
Thanks again for taking the time to test. Here you can find the build with fixes. I added parts name detection. |
Latest changes look good to me. Adding support for Item 2 still isn't fixed, but I'll handle that in the future so don't worry about it. Its related to differences between what we send to our completion engine and what VS uses internally and I'm seeing that affect other places too, and in #302 I hinted I wanted to rework that aspect anyway, but that's a bigger project |
3e8684d
to
decbcd5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly just typos in "public" (or relating to public) members. I've only tagged their declaration, the usages will need to be updated too - but VS's renaming refactor should make that easy
CompletionEngine/Avalonia.Ide.CompletionEngine/Completion/CompletionEngine.cs
Outdated
Show resolved
Hide resolved
CompletionEngine/Avalonia.Ide.CompletionEngine/Completion/CompletionEngine.cs
Outdated
Show resolved
Hide resolved
CompletionEngine/Avalonia.Ide.CompletionEngine/Parsing/SelectorParser.cs
Outdated
Show resolved
Hide resolved
CompletionEngine/Avalonia.Ide.CompletionEngine/Parsing/SelectorParser.cs
Outdated
Show resolved
Hide resolved
CompletionEngine/Avalonia.Ide.CompletionEngine/Parsing/SelectorParser.cs
Outdated
Show resolved
Hide resolved
CompletionEngine/Avalonia.Ide.CompletionEngine/Parsing/SelectorParser.cs
Outdated
Show resolved
Hide resolved
CompletionEngine/Avalonia.Ide.CompletionEngine/Parsing/SelectorParser.cs
Outdated
Show resolved
Hide resolved
CompletionEngine/Avalonia.Ide.CompletionEngine/Parsing/SelectorParser.cs
Outdated
Show resolved
Hide resolved
CompletionEngine/Avalonia.Ide.CompletionEngine/Parsing/SelectorParser.cs
Outdated
Show resolved
Hide resolved
Sorry for the delay in approving/merging these PRs, we've not had much time recently to review the VS extension PRs. Will try to resolve that shortly. |
e4d658f
to
7817aad
Compare
Allow autocompletate for selector: