-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MVP of Accessibility/UI automation support #5177
Merged
Merged
Changes from 75 commits
Commits
Show all changes
86 commits
Select commit
Hold shift + click to select a range
2a44d8b
Initial implementation of UI automation.
grokys c1dfc1f
Started adding integration tests.
grokys e8801c2
Started adding ComboBox integration tests.
grokys 5f551a2
Make integration tests ordered.
grokys 2e23333
Add CheckBox tests.
grokys 651106a
Use Name for AutomationId.
grokys 8b642a9
Implemented LabeledBy.
grokys 06ed896
Added access/accelerator key support.
grokys 3fcfe4d
Notify UIA that a window has been destroyed.
grokys bd0d973
Use Group as generic control type.
grokys acc40a7
Add context menu automation peer.
grokys 7f42229
Don't use C#9 features.
grokys c876a19
Merge branch 'master' into feature/ui-automation
grokys 8add237
Make root automation node come from OS.
grokys 1c60374
Use correct peer for TabItems.
grokys a475157
Merge branch 'master' into feature/ui-automation
grokys 7bb2647
Fix AccessText after merge.
grokys d6d583a
Initial implementation of OSX automation.
grokys bcc8876
Handle children changing.
grokys 7bbbfa4
More OSX accessibility implementation.
grokys 0ab5e4d
Implemented a11y focus on OSX.
grokys 1553b89
Fix a11y for popup windows.
grokys 6096cab
Use correct role for combobox items on OSX.
grokys 8ded356
More work on ComboBox OSX a11y.
grokys 2df1e32
Expose max/min for slider controls etc.
grokys 3f53126
Merge branch 'master' into feature/ui-automation
grokys 7ca502e
Update ApiCompatBaseline.txt
grokys c34a825
Try to fix problem with ComboBox.
grokys acb49d6
Revert "Try to fix problem with ComboBox."
grokys 11c60b4
Decouple automation peers from platform nodes.
grokys 8ffbbfb
Create root automation nodes like others.
grokys ae89057
Use non-obsolete interface.
grokys 26419fc
Added AutomationControlType.None.
grokys a5c28de
Reinstate ControlAutomationPeerTests.
grokys 54d9ba7
Allow peers to dynamically expose implemented interfaces.
grokys 49ef4b3
Added AccessibilityView and ControlType.
grokys 0756c1b
Use new properties to remove some peers.
grokys eebcaca
Query correct interface.
grokys 0388a7b
Merge branch 'master' into feature/ui-automation
grokys f4f478c
Move ChildrenChanged to AutomationPeer.
grokys 651fffd
Merge branch 'master' into feature/ui-automation
grokys bc12867
Make OSX a11y work again.
grokys ab15b8e
Try to prevent leaks.
grokys af588cc
Stop warning.
grokys dab63d3
Merge branch 'master' into feature/ui-automation
grokys e253b6c
Merge branch 'master' into feature/ui-automation
grokys e0d3799
Update IntegrationTestApp to net6.0.
grokys 77f535f
Trying to use a shared project for win32/mac integration tests.
grokys 32e76d3
WIP: Bundle IntegrationTestApp.
grokys 9b9abb2
Added script to create bundle.
grokys cab21b6
Start making automation tests work on macOS.
grokys 71b84b3
Correctly raise layout changed notification (?)
grokys 812bf26
Get CheckBox automation tests passing on macOS.
grokys 8250131
Rename integration tests now they're not win32-only.
grokys 66923cd
Skip accelerator key test on OSX.
grokys 6b17707
Raise focus changed on new window if it has focus.
grokys f4d9d4c
Make integration tests pass on MacOS.
grokys dc83f8e
Use ListItemAutomationPeer for TabItem.
grokys 5534e66
Implement isAccessibilitySelected.
grokys 610ef6f
Added a NativeMenu test for macOS.
grokys f6e06a6
Refactored Menu integration tests.
grokys 742d960
Remove rogue character.
grokys 33ca12c
Remove faulty cast.
grokys ddb6ab9
Refactored ComboBox integration tests.
grokys 26137ca
Trying to get stuff working on macOS.
grokys b4a183b
Skip keyboard interaction tests on macOS.
grokys 261f46e
Added a few ListBox tests.
grokys 9f807c9
Sigh. Appium sucks.
grokys 6da59f9
Added integration tests readme.
grokys bfbe425
Merge branch 'master' into feature/ui-automation
grokys e89bd58
Add additional macOS prerequisite.
grokys 7f8624e
Updated ApiCompat.
grokys 26eaa8d
Merge branch 'master' into feature/ui-automation
jmacato cc4cfa6
Throw when interface not supported.
grokys 98a070e
Implement provider members as explicit interface members.
grokys 1d665c5
Fix leak in GetNSStringAndRelease.
grokys bff4616
Don't run integration tests under ncrunch.
grokys 3194d45
Merge branch 'master' into feature/ui-automation
grokys 09e3261
Changed by VS.
grokys 7581ce2
Remove non-existent project.
grokys 72beb30
Cast to interface instead of concrete type.
grokys d6b09a9
Use correct interface for root window impl.
grokys 7a9d21f
Merge branch 'master' into feature/ui-automation
grokys b9f9d4d
Fix nullable errors after merge.
grokys b2eddaa
Merge branch 'master' into feature/ui-automation
grokys b244197
Merge branch 'master' into feature/ui-automation
grokys File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| <ProjectConfiguration> | ||
| <Settings> | ||
| <IgnoreThisComponentCompletely>True</IgnoreThisComponentCompletely> | ||
| </Settings> | ||
| </ProjectConfiguration> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| <ProjectConfiguration> | ||
| <Settings> | ||
| <IgnoreThisComponentCompletely>True</IgnoreThisComponentCompletely> | ||
| </Settings> | ||
| </ProjectConfiguration> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| #import <Cocoa/Cocoa.h> | ||
| #include "window.h" | ||
|
|
||
| NS_ASSUME_NONNULL_BEGIN | ||
|
|
||
| class IAvnAutomationPeer; | ||
|
|
||
| @interface AvnAccessibilityElement : NSAccessibilityElement | ||
| + (AvnAccessibilityElement *) acquire:(IAvnAutomationPeer *) peer; | ||
| @end | ||
|
|
||
| NS_ASSUME_NONNULL_END |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait... This never releases when the
NSStringreturns above?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, looks like a mistake 👍