WIP: update build #3596
Closed
WIP: update build #3596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kekekeks
reviewed
Feb 20, 2020
| Information($"Running tests from {projectName}"); | ||
| var project = Solution.GetProject(projectName).NotNull("project != null"); | ||
|
|
||
| foreach (var fw in project.GetTargetFrameworks()) |
There was a problem hiding this comment.
Does it use MSBuild evaluation or parses stuff manually? We've seen issues with MSBuild on not-quite-supported OSes
There was a problem hiding this comment.
It uses MSBuild for evaluation. Could you try on those not-quite-supported environments?
nukebuild/_build.csproj
Outdated
| @@ -2,15 +2,15 @@ | |||
|
|
|||
| <PropertyGroup> | |||
| <OutputType>Exe</OutputType> | |||
| <TargetFramework>netcoreapp2.0</TargetFramework> | |||
| <TargetFramework>netcoreapp3.0</TargetFramework> | |||
There was a problem hiding this comment.
This TFM was failing for me on several machines with .NET Core SDK 3.1 installed. Could we use netcoreapp3.1 instead?
There was a problem hiding this comment.
I guess so, let me try.
|
@matkoch what's the progress on this? The OSX build seems to be failing because the wrong version of .NET core is being installed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.