Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[macOS] Prevent popups from stealing focus #17794

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

MrJul
Copy link
Member

@MrJul MrJul commented Dec 17, 2024

What does the pull request do?

On macOS, this PR prevents popups from stealing the focus, when their parent are inactive windows.

What is the current behavior?

Any tooltip or popup opening steals the focus from the active application (easy to trigger unexpectedly by hovering the mouse over an inactive window having a tooltip).

What is the updated/expected behavior with this PR?

The popup now only gets the focus if its parent is active.

@MrJul MrJul added bug os-macos customer-priority Issue reported by a customer with a support agreement. backport-candidate-11.2.x Consider this PR for backporting to 11.2 branch labels Dec 17, 2024
@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.3.999-cibuild0054009-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@MrJul MrJul added this pull request to the merge queue Dec 17, 2024
Merged via the queue into AvaloniaUI:master with commit 032cdcb Dec 17, 2024
11 checks passed
@MrJul MrJul deleted the fix/macos-popup-focus branch December 17, 2024 18:30
@maxkatz6 maxkatz6 removed the backport-candidate-11.2.x Consider this PR for backporting to 11.2 branch label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported-11.2.x bug customer-priority Issue reported by a customer with a support agreement. os-macos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants