Typeface simulation fixes #17399
Typeface simulation fixes #17399
Conversation
|
You can test this PR using the following package version. |
maxkatz6
added
the
backport-candidate-11.2.x
| @@ -12,6 +12,7 @@ namespace Avalonia.Media.Fonts | |||
| public abstract class FontCollectionBase : IFontCollection | |||
| { | |||
| protected readonly ConcurrentDictionary<string, ConcurrentDictionary<FontCollectionKey, IGlyphTypeface?>> _glyphTypefaceCache = new(); | |||
| protected IFontManagerImpl? _fontManager; | |||
There was a problem hiding this comment.
I don't think we should expose such a field publicly (same for _glyphTypefaceCache above, but that ship has sailed - it should probably be removed in v12).
Instead, TryCreateSynthethicGlyphTypeface() could be static and take an extra IFontManagerImpl parameter. Each of SystemFontCollection and EmbeddedFontCollection can keep their existing private field.
There was a problem hiding this comment.
Y you are right these members should be hidden behind some limited public API
The font collection feature should have been marked unstable because it needed frequent changes.
| @@ -80,6 +81,47 @@ IEnumerator IEnumerable.GetEnumerator() | |||
| return GetEnumerator(); | |||
| } | |||
|
|
|||
| protected bool TryCreateSyntheticGlyphTypeface(IGlyphTypeface glyphTypeface, FontStyle style, FontWeight weight, | |||
There was a problem hiding this comment.
Should probably be private protected so it isn't part of the public API.
There was a problem hiding this comment.
I have moved that method to FontManger and made it internal
Gillibald
force-pushed
the
typefaceSimulationTests
branch
from
43faf03 to
a215d97
Compare
|
This should no longer have any public API changes |
|
You can test this PR using the following package version. |
|
You can test this PR using the following package version. |
|
You can test this PR using the following package version. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Co-authored-by: Julien Lebosquain <[email protected]>
maxkatz6
added
backported-11.2.x
and removed
backport-candidate-11.2.x
What does the pull request do?
This PR ensures the system font collection tries to create a synthetic typeface if no match is found. This matches what the embedded font collection did in the past.
What is the current behavior?
What is the updated/expected behavior with this PR?
How was the solution implemented (if it's not obvious)?
Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues