Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor data converter for databricks topic #2255

Merged

Conversation

toan-quach
Copy link
Member

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Refactoring code for databricks integration on enterprise

Related Tickets & Documents

  • Related Issue #
  • Closes #

How to reproduce the issue

Please replace this line with instructions on how to reproduce the issue or test the feature.

Other branches or releases that this needs to be backported

Describe which projects this change will impact and that needs to be backported.

Checklist

We encourage you to keep the code coverage percentage at 80% and above.

  • Does this solution meet the acceptance criteria of the related issue?
  • Is the related issue checklist completed?
  • Does this PR adds unit tests for the developed code? If not, why?
  • End-to-End tests have been added or updated?
  • Was the documentation updated, or a dedicated issue for documentation created? (If applicable)
  • Is the release notes updated? (If applicable)

@toan-quach toan-quach self-assigned this Nov 18, 2024
Copy link
Contributor

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
19296 16781 87% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
taipy/core/data/_data_converter.py 99% 🟢
TOTAL 99% 🟢

updated for commit: 309fceb by action🐍

Copy link
Member

@jrobinAV jrobinAV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to add tests for the two new methods _serialize_properties and _deserialize_properties ?

@toan-quach
Copy link
Member Author

@jrobinAV they're already tested by the existing tests. But if we want to test them separately, we can too. Though I don't think it's necessary

@jrobinAV jrobinAV merged commit 99d4fd0 into develop Nov 19, 2024
126 checks passed
@jrobinAV jrobinAV deleted the feature/#521-refactor-code-for-databricks-integration branch November 19, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants