New feature implementation/#2189 Add support for uploading nested folders #2206
+189
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
… of React's attribute naming; Adjusted tests for addition of other attributes.
…upload_files (addresses linter C901) .
FredLL-Avaiga
added
🖰 GUI
…parison to `None` should be `cond is None`"; "W293 [*] Blank line contains whitespace"
…c814c75098c8ec1750a74e3770
…for different input casing;
FredLL-Avaiga
added
the
✅ hacktoberfest: approved
FredLL-Avaiga
approved these changes
Nov 13, 2024
There was a problem hiding this comment.
looks good to me
Can you do your hacktoberFest thing @jrobinAV ?
jrobinAV
added
hacktoberfest
|
@jrobinAV I've just taken a look at the goodies and they seem pretty sweet. Do I have to sign up somewhere to get them ? |
|
@RymMichaut should contact you very soon. |
|
@JosuaCarl congrats on the merged PR, could you please contact me at [email protected] to ship your swag? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2189
Implementation:
webkitdirectoryin the<include ...>block, which delivers the directory structure, relative to the point of entry as thewebkitRelativePathattribute of ablob / file.bloband added thefilePathvariable, containing the mentioned relative path, to theFormDataof the request/tmpby default)Limitations:
webkitdirectoryas an option forInputHTMLAttributes, so it is added as an attribute (see JSX render won't allow webkitdirectory and directory to be used facebook/react#3468 (comment)), which conflicts with the TypeScript ESLint guidelinesHelp needed: