-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Input control validation on focus out event #2036
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any tests
if (changeDelay > 0 && delayCall.current > 0) { | ||
clearTimeout(delayCall.current); | ||
delayCall.current = -1; | ||
dispatch(createSendUpdateAction(updateVarName, val, module, onChange, propagate)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should always be called
So put outside the if/else block
I think you're right this should only be called if there is delayed call on hold
Sorry about the noise
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But I still don't see any tests ;-)
Are you still working on this @kart2004 ?
hey @kart2004, congrats on the merged PR. |
@kart2004 Please let us know if you wish to finish this work or let us handle this. |
please @kart2004 respond before EoW to ship, or you'd miss your swag |
Description:
Key changes include:
Ensured