Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@WillFP
Finally found source of display bug that causes enchants to not appear and armor tiers to display as %tier%. Usually the PacketWindowItems onSend is called once per event, but sometimes it's called an additional 3 times with the windowId set to 0. This infrequent case caused the display to break because
player.lastDisplayFrame
was not set to empty during those additional calls. I also fixed a packet type that I think you intended to use in PacketHeldWindowItems.I've tested this on 1.19.2 with displayframes set to true, and it works without any issues that I can see. Small bug XD
This should resolve Auxilor/EcoEnchants#299 and resolve Auxilor/EcoEnchants#303
Let me know if you want me to get any more debug info