Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CircleCI api changed- updating calls #83

Merged
merged 1 commit into from
Dec 10, 2019

Conversation

bsessions85
Copy link
Contributor

The call we were using to get the workflow id was failing because the api changed. This was causing gituhub to not have a link to the job until the job was complete.

To Test:
Run locally and make sure that the github PR is updated with a link to the workflow

@bsessions85 bsessions85 requested a review from Stojdza December 10, 2019 15:13
@bsessions85 bsessions85 self-assigned this Dec 10, 2019
Copy link
Contributor

@Stojdza Stojdza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bsessions85 bsessions85 merged commit 942a72d into master Dec 10, 2019
@bsessions85 bsessions85 deleted the update/workflows-api-calls branch December 10, 2019 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants