Newsletter settings: Show copy and error asking user to choose categories.

[allilevine]

Proposed Changes

See: p1734114241935889/1733936868.332319-slack-C083ZPVVDTK

• Show "Which categories will you use for newsletter subscribers? Select all that apply:" above the newsletter category selection.

• Show an error message when newsletter categories are enabled, but none are selected: "Please select at least one category when newsletter categories are enabled."

Noting that:

• I'd like to add a test for the error, but I had an issue with how the component is exported. I might need to do some refactoring.
• This will need translations once the copy is finalized.

Why are these changes being made?

• To improve the UX. It wasn't clear that you needed to select categories.

Testing Instructions

• Go to /settings/newsletter/ > Newsletter categories.
• Enable categories.
• Without selecting any, click "Save settings."
• You should see an error, and settings won't save.
• Select one or more categories.
• Settings should save successfully.
• Disable categories.
• Settings should save successfully.

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-127612

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-127612&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-127612&env=a8c-for-agencies

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~120 bytes added 📈 [gzipped])

name                 parsed_size           gzip_size
settings-newsletter       +332 B  (+0.1%)     +120 B  (+0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[matticbot]

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

• notifications
• wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/newsletter-category-settings on your sandbox.

[DustyReagan]

This seems to be working as intended if you select the "Save settings" button in the "Newsletter categories" box, but it looks like you can bypass the error check if you click the "Save settings" button in another section.

Screen.Recording.2024-12-13.at.3.55.27.PM.mp4

[allilevine]

This seems to be working as intended if you select the "Save settings" button in the "Newsletter categories" box, but it looks like you can bypass the error check if you click the "Save settings" button in another section.

Screen.Recording.2024-12-13.at.3.55.27.PM.mp4

@DustyReagan Thanks! I was thinking every button was overkill, since this is more of a reminder, but now I can see someone clicking the lower button to save. I'll update it.

[DustyReagan]

Works well! I can trigger the error check from any save button on the page, and all the other settings are saving correctly.