Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help Center: fire event when requesting support #97419

Merged
merged 3 commits into from
Dec 12, 2024

Conversation

escapemanuele
Copy link
Contributor

@escapemanuele escapemanuele commented Dec 12, 2024

Related to #

Proposed Changes

image

Fire an event when the button is clicked.

Testing Instructions

  • Check that calypso_odie_chat_get_support is fired

@escapemanuele escapemanuele changed the title Help Center: fi Help Center: fire event when requesting support Dec 12, 2024
@escapemanuele escapemanuele self-assigned this Dec 12, 2024
@escapemanuele escapemanuele requested a review from a team December 12, 2024 15:55
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 12, 2024
@matticbot
Copy link
Contributor

matticbot commented Dec 12, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Async-loaded Components (~30 bytes added 📈 [gzipped])

name                               parsed_size           gzip_size
async-load-automattic-help-center        +72 B  (+0.0%)      +30 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • help-center
  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug hc-track-talk-to-human on your sandbox.

@escapemanuele escapemanuele merged commit cbfccb0 into trunk Dec 12, 2024
11 checks passed
@escapemanuele escapemanuele deleted the hc-track-talk-to-human branch December 12, 2024 16:49
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 12, 2024
timur987 pushed a commit that referenced this pull request Dec 13, 2024
* Use selectedSite from storage

* Fire event when clicking on get support

* Remove unrelated code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants