-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Stepper performance bug #97354
Merged
Merged
Fix Stepper performance bug #97354
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,80 @@ | ||
| import config from '@automattic/calypso-config'; | ||
| import page from '@automattic/calypso-router'; | ||
| import { addBreadcrumb, initSentry } from '@automattic/calypso-sentry'; | ||
| import { tracksEvents } from 'calypso/lib/analytics/tracks'; | ||
| import Logger from 'calypso/lib/catch-js-errors'; | ||
| import { getSiteFragment } from 'calypso/lib/route'; | ||
| import { getCurrentUserId } from 'calypso/state/current-user/selectors'; | ||
| import { getSelectedSiteId, getSectionName } from 'calypso/state/ui/selectors'; | ||
|
|
||
| export function setupErrorLogger( reduxStore ) { | ||
| // Add a bit of metadata from the redux store to the sentry event. | ||
| const beforeSend = ( event ) => { | ||
| const state = reduxStore.getState(); | ||
| const tags = { | ||
| blog_id: getSelectedSiteId( state ), | ||
| calypso_section: getSectionName( state ), | ||
| }; | ||
|
|
||
| event.tags = { | ||
| ...tags, | ||
| ...event.tags, | ||
| }; | ||
|
|
||
| return event; | ||
| }; | ||
|
|
||
| // Note that Sentry can disable itself and do some cleanup if needed, so we | ||
| // run it before the catch-js-errors check. (Otherwise, cleanup would never | ||
| // never happen.) | ||
| initSentry( { beforeSend, userId: getCurrentUserId( reduxStore.getState() ) } ); | ||
|
|
||
| if ( ! config.isEnabled( 'catch-js-errors' ) ) { | ||
| return; | ||
| } | ||
|
|
||
| // At this point, the normal error logger is still set up so that logstash | ||
| // contains a definitive log of calypso errors. | ||
| const errorLogger = new Logger(); | ||
|
|
||
| // Save errorLogger to a singleton for use in arbitrary logging. | ||
| require( 'calypso/lib/catch-js-errors/log' ).registerLogger( errorLogger ); | ||
|
|
||
| // Save data to JS error logger | ||
| errorLogger.saveDiagnosticData( { | ||
| user_id: getCurrentUserId( reduxStore.getState() ), | ||
| calypso_env: config( 'env_id' ), | ||
| } ); | ||
|
|
||
| errorLogger.saveDiagnosticReducer( function () { | ||
| const state = reduxStore.getState(); | ||
| return { | ||
| blog_id: getSelectedSiteId( state ), | ||
| calypso_section: getSectionName( state ), | ||
| }; | ||
| } ); | ||
|
|
||
| tracksEvents.on( 'record-event', ( eventName, lastTracksEvent ) => | ||
| errorLogger.saveExtraData( { lastTracksEvent } ) | ||
| ); | ||
|
|
||
| let prevPath; | ||
| page( '*', function ( context, next ) { | ||
| const path = context.canonicalPath.replace( | ||
| getSiteFragment( context.canonicalPath ), | ||
| ':siteId' | ||
| ); | ||
| // Also save the context to Sentry for easier debugging. | ||
| addBreadcrumb( { | ||
| category: 'navigation', | ||
| data: { | ||
| from: prevPath ?? path, | ||
| to: path, | ||
| should_capture: true, // Hint that this is our own breadcrumb, not the default navigation one. | ||
| }, | ||
| } ); | ||
| prevPath = path; | ||
| errorLogger.saveNewPath( path ); | ||
| next(); | ||
| } ); | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A better location for this module would be
calypso/lib/error-logger. Thebootfolder should contain only the minimal boot code and import most stuff from elsewhere. Let's not repeat the mistake when we stuffed the entire Stepper framework intoclient/landing🙂