Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reader: Update Reader Conversations copy #97353

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

DustyReagan
Copy link
Member

@DustyReagan DustyReagan commented Dec 11, 2024

Related to https://github.com/Automattic/loop/issues/258 and D168390-code

Proposed Changes

  • This PR updates the copy of the Conversations sections to be more informative and removes the mention of Likes since they're removed in D168390-code
  • It also fixes an issue so that the specialized intro copy for /read/conversations/a8c appears as initially intended.
Before After
Screenshot 2024-12-11 at 1 51 42 PM Screenshot 2024-12-11 at 1 50 34 PM
Before After
Screenshot 2024-12-11 at 1 51 53 PM Screenshot 2024-12-11 at 1 50 49 PM
Before After
Screenshot 2024-12-11 at 1 52 12 PM Screenshot 2024-12-11 at 1 52 31 PM

Why are these changes being made?

  • Create clarity around the functionality of the Conversations section.

Testing Instructions

  • Use Calypso Live
  • Go to /read/conversations/a8c and /read/conversations
  • Ensure the copy makes sense

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@DustyReagan DustyReagan self-assigned this Dec 11, 2024
@matticbot
Copy link
Contributor

matticbot commented Dec 11, 2024

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/reader-conversations-intro on your sandbox.

@matticbot
Copy link
Contributor

matticbot commented Dec 11, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~13 bytes added 📈 [gzipped])

name    parsed_size           gzip_size
reader        +17 B  (+0.0%)      +13 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@DustyReagan DustyReagan marked this pull request as ready for review December 11, 2024 19:56
@DustyReagan DustyReagan requested a review from a team as a code owner December 11, 2024 19:56
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 11, 2024
@DustyReagan DustyReagan added the [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging label Dec 11, 2024
@a8ci18n
Copy link

a8ci18n commented Dec 11, 2024

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17058815

Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @DustyReagan for including a screenshot in the description! This is really helpful for our translators.

@DustyReagan DustyReagan merged commit db09c5c into trunk Dec 13, 2024
11 of 12 checks passed
@DustyReagan DustyReagan deleted the update/reader-conversations-intro branch December 13, 2024 15:04
@github-actions github-actions bot removed [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Dec 13, 2024
@a8ci18n
Copy link

a8ci18n commented Dec 13, 2024

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants